fix: allow objects with a null prototype in binary packets (#114)

Gabba90 · web-flow · commit 7f6b262ac83b · 2022-02-17T07:18:11.000+01:00
diff --git a/lib/binary.ts b/lib/binary.ts
@@ -33,7 +33,7 @@ function _deconstructPacket(data, buffers) {
   } else if (typeof data === "object" && !(data instanceof Date)) {
     const newData = {};
     for (const key in data) {
-      if (data.hasOwnProperty(key)) {
+      if (Object.prototype.hasOwnProperty.call(data, key)) {
         newData[key] = _deconstructPacket(data[key], buffers);
       }
     }
@@ -68,7 +68,7 @@ function _reconstructPacket(data, buffers) {
     }
   } else if (typeof data === "object") {
     for (const key in data) {
-      if (data.hasOwnProperty(key)) {
+      if (Object.prototype.hasOwnProperty.call(data, key)) {
         data[key] = _reconstructPacket(data[key], buffers);
       }
     }
diff --git a/test/arraybuffer.js b/test/arraybuffer.js
@@ -14,6 +14,21 @@ describe("parser", () => {
     helpers.test_bin(packet, done);
   });
 
+  it("encodes an ArrayBuffer into an object with a null prototype", (done) => {
+    const packet = {
+      type: PacketType.EVENT,
+      data: [
+        "a",
+        Object.create(null, {
+          array: { value: new ArrayBuffer(2), enumerable: true },
+        }),
+      ],
+      id: 0,
+      nsp: "/",
+    };
+    helpers.test_bin(packet, done);
+  });
+
   it("encodes a TypedArray", (done) => {
     const array = new Uint8Array(5);
     for (let i = 0; i < array.length; i++) array[i] = i;

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ function _deconstructPacket(data, buffers) {`
`33`	`33`	`} else if (typeof data === "object" && !(data instanceof Date)) {`
`34`	`34`	`const newData = {};`
`35`	`35`	`for (const key in data) {`
`36`		`- if (data.hasOwnProperty(key)) {`
	`36`	`+ if (Object.prototype.hasOwnProperty.call(data, key)) {`
`37`	`37`	`newData[key] = _deconstructPacket(data[key], buffers);`
`38`	`38`	`}`
`39`	`39`	`}`
`@@ -68,7 +68,7 @@ function _reconstructPacket(data, buffers) {`
`68`	`68`	`}`
`69`	`69`	`} else if (typeof data === "object") {`
`70`	`70`	`for (const key in data) {`
`71`		`- if (data.hasOwnProperty(key)) {`
	`71`	`+ if (Object.prototype.hasOwnProperty.call(data, key)) {`
`72`	`72`	`data[key] = _reconstructPacket(data[key], buffers);`
`73`	`73`	`}`
`74`	`74`	`}`