Merge pull request adafruit#1541 from FoamyGuy/fix_filter_null_search

dhalbert · web-flow · commit 196fe9ae27c2 · 2024-11-22T11:58:51.000-05:00
fix filtering for null search term
diff --git a/assets/javascript/downloads.js b/assets/javascript/downloads.js
@@ -351,29 +351,35 @@ function filterResults() {
       download.style.display = 'block';
       board_count++;
       // exact tag match re-order
-      let searched = downloadsSearch.searchTerm.toLowerCase();
-      let tags = download.getAttribute("data-tags").split(",");
-      if (tags.indexOf(searched) >= 0 ){
+      if (downloadsSearch.searchTerm !== null && downloadsSearch.searchTerm !== undefined) {
+        let searched = downloadsSearch.searchTerm.toLowerCase();
+        let tags = download.getAttribute("data-tags").split(",");
+        if (searched !== "" && tags.indexOf(searched) >= 0) {
           let parent = download.parentElement;
           parent.removeChild(download);
           parent.prepend(download);
-
+        }
       }
     }
   });
   document.getElementById("board_count").innerHTML = board_count;
 }
 
 function handleSortResults(event) {
-  let searched = downloadsSearch.searchTerm.toLowerCase();
+  let searched;
+  if (downloadsSearch.searchTerm !== null && downloadsSearch.searchTerm !== undefined) {
+    searched = downloadsSearch.searchTerm.toLowerCase();
+  }
   var sortType = event.target.value;
   setURL('sort-by', sortType);
   var downloads = document.querySelector('.downloads-section');
   Array.prototype.slice.call(downloads.children)
     .map(function (download) { return downloads.removeChild(download); })
     .sort(function (a, b) {
       // exact tag match re-order
-      if (a.dataset.tags.split(",").indexOf(searched) >= 0){
+      if (searched !== undefined && searched !== "" &&
+          a.dataset.tags.split(",").indexOf(searched) >= 0){
+
         return -2;
       }
       switch(sortType) {
