fix compiler warnings

lovasoa · lovasoa · commit df358751f5b3 · 2023-11-28T13:58:13.000Z
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
@@ -85,47 +85,15 @@ RUN echo 'export EM_NODE_JS="$EMSDK_NODE"' >> /etc/bash.bashrc
 # List taken from:
 # https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md#chrome-headless-doesnt-launch-on-unix
 RUN apt-get update \
-     && apt-get install -y \
-        ca-certificates \
-        fonts-liberation \
-        libappindicator3-1 \
-        libasound2 \
-        libatk-bridge2.0-0 \
-        libatk1.0-0 \
-        libc6 \
-        libcairo2 \
-        libcups2 \
-        libdbus-1-3 \
-        libexpat1 \
-        libfontconfig1 \
-        libgbm1 \
-        libgcc1 \
-        libglib2.0-0 \
-        libgtk-3-0 \
-        libnspr4 \
-        libnss3 \
-        libpango-1.0-0 \
-        libpangocairo-1.0-0 \
-        libstdc++6 \
-        libx11-6 \
-        libx11-xcb1 \
-        libxcb1 \
-        libxcomposite1 \
-        libxcursor1 \
-        libxdamage1 \
-        libxext6 \
-        libxfixes3 \
-        libxi6 \
-        libxrandr2 \
-        libxrender1 \
-        libxss1 \
-        libxtst6 \
-        lsb-release \
-        wget \
-        xdg-utils
-
-# Installs the command "sha3sum", which is used check the download integrity of sqlite source.
-RUN apt-get install -y libdigest-sha3-perl
+    && apt-get install -y wget gnupg \
+    && wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - \
+    && sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list' \
+    && apt-get update \
+    && apt-get install -y google-chrome-stable fonts-freefont-ttf libxss1 libxshmfence1 libglu1 \
+      --no-install-recommends \
+    # Installs the command "sha3sum", which is used check the download integrity of sqlite source.
+    && apt-get install -y libdigest-sha3-perl \
+    && rm -rf /var/lib/apt/lists/*
 
 # We set this env variable (RUN_WORKER_TEST_WITHOUT_PUPPETEER_SANDBOX=1) this to tell our sql.js test harness to run Puppeteer without the sandbox.
 # Otherwise, when we instantiate Puppeteer, we get this error: 
diff --git a/src/api.js b/src/api.js
@@ -279,7 +279,7 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
 
     /** @typedef {string|number|null|Uint8Array} Database.SqlValue */
     /** @typedef {
-        Database.SqlValue[]|Object<string, Database.SqlValue>|null
+        Array<Database.SqlValue>|Object<string, Database.SqlValue>|null
     } Statement.BindParams
      */
 
@@ -406,7 +406,7 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
     If the first parameter is not provided, step must have been called before.
     @param {Statement.BindParams} [params] If set, the values will be bound
     to the statement before it is executed
-    @return {Database.SqlValue[]} One row of result
+    @return {Array<Database.SqlValue>} One row of result
 
     @example
     <caption>Print all the rows of the table test to the console</caption>
@@ -449,7 +449,7 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
     };
 
     /** Get the list of column names of a row of result of a statement.
-    @return {string[]} The names of the columns
+    @return {Array<string>} The names of the columns
     @example
     var stmt = db.prepare(
         "SELECT 5 AS nbr, x'616200' AS data, NULL AS null_value;"
@@ -638,7 +638,7 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
     };
 
     /** Bind values to numbered parameters
-    @param {Database.SqlValue[]} values
+    @param {Array<Database.SqlValue>} values
     @private
     @nodoc
      */
@@ -819,7 +819,7 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
     * @memberof module:SqlJs
     * Open a new database either by creating a new one or opening an existing
     * one stored in the byte array passed in first argument
-    * @param {number[]} data An array of bytes representing
+    * @param {Array<number>} data An array of bytes representing
     * an SQLite database file
     */
     function Database(data) {
@@ -872,12 +872,12 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
 
     /**
      * @typedef {{
-        columns:string[],
-        values:Database.SqlValue[][]
+        columns:Array<string>,
+        values:Array<Array<Database.SqlValue>>
     }} Database.QueryExecResult
-     * @property {string[]} columns the name of the columns of the result
+     * @property {Array<string>} columns the name of the columns of the result
      * (as returned by {@link Statement.getColumnNames})
-     * @property {Database.SqlValue[][]} values one array per row, containing
+     * @property {Array<Array<Database.SqlValue>>} values one array per row, containing
      * the column values
      */
 
@@ -934,7 +934,7 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
     before it is executed. If you use the params argument as an array,
     you **cannot** provide an sql string that contains several statements
     (separated by `;`). This limitation does not apply to params as an object.
-    * @return {Database.QueryExecResult[]} The results of each statement
+    * @return {Array<Database.QueryExecResult>} The results of each statement
     */
     Database.prototype["exec"] = function exec(sql, params, config) {
         if (!this.db) {
@@ -995,7 +995,7 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
 
     @param {string} sql A string of SQL text. Can contain placeholders
     that will be bound to the parameters given as the second argument
-    @param {Statement.BindParams} [params=[]] Parameters to bind to the query
+    @param {Statement.BindParams=} [params=] Parameters to bind to the query
     @param {function(Object<string, Database.SqlValue>):void} callback
     Function to call on each row of result
     @param {function():void} done A function that will be called when
@@ -1206,7 +1206,7 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
 
       @param {string} name the name of the function as referenced in
       SQL statements.
-      @param {function} func the actual function to be executed.
+      @param {function(any)} func the actual function to be executed.
       @return {Database} The database object. Useful for method chaining
        */
     Database.prototype["create_function"] = function create_function(
@@ -1259,15 +1259,15 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
       SQL statements.
       @param {object} aggregateFunctions
                       object containing at least a step function.
-      @param {function(): T} [aggregateFunctions.init = ()=>null]
+      @param {function(): T} [aggregateFunctions.init=]
             a function receiving no arguments and returning an initial
             value for the aggregate function. The initial value will be
             null if this key is omitted.
       @param {function(T, any) : T} aggregateFunctions.step
             a function receiving the current state and a value to aggregate
             and returning a new state.
             Will receive the value from init for the first step.
-      @param {function(T): any} [aggregateFunctions.finalize = (state)=>state]
+      @param {function(T): any} [aggregateFunctions.finalize=]
             a function returning the result of the aggregate function
             given its final state.
             If omitted, the value returned by the last step
