Remove redundant text.length() checks

SharmaNishchay · SharmaNishchay · commit 52d7224f13ed · 2025-03-11T21:51:14.000+05:30
diff --git a/src/sqlancer/mysql/ast/MySQLBinaryOperation.java b/src/sqlancer/mysql/ast/MySQLBinaryOperation.java
@@ -78,20 +78,20 @@ public MySQLConstant getExpectedValue() {
         /* workaround for https://bugs.mysql.com/bug.php?id=95960 */
         if (leftExpected.isString()) {
             String text = leftExpected.castAsString();
-            while ((text.startsWith(" ") || text.startsWith("\t")) && !text.isEmpty()) {
+            while (text.startsWith(" ") || text.startsWith("\t")) {
                 text = text.substring(1);
             }
-            if (!text.isEmpty() && (text.startsWith("\n") || text.startsWith("."))) {
+            if (text.startsWith("\n") || text.startsWith(".")) {
                 throw new IgnoreMeException();
             }
         }
 
         if (rightExpected.isString()) {
             String text = rightExpected.castAsString();
-            while ((text.startsWith(" ") || text.startsWith("\t")) && !text.isEmpty()) {
+            while (text.startsWith(" ") || text.startsWith("\t")) {
                 text = text.substring(1);
             }
-            if (!text.isEmpty() && (text.startsWith("\n") || text.startsWith("."))) {
+            if (text.startsWith("\n") || text.startsWith(".")) {
                 throw new IgnoreMeException();
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -78,20 +78,20 @@ public MySQLConstant getExpectedValue() {`
`78`	`78`	`/* workaround for https://bugs.mysql.com/bug.php?id=95960 */`
`79`	`79`	`if (leftExpected.isString()) {`
`80`	`80`	`String text = leftExpected.castAsString();`
`81`		`- while ((text.startsWith(" ") \|\| text.startsWith("\t")) && !text.isEmpty()) {`
	`81`	`+ while (text.startsWith(" ") \|\| text.startsWith("\t")) {`
`82`	`82`	`text = text.substring(1);`
`83`	`83`	`}`
`84`		`- if (!text.isEmpty() && (text.startsWith("\n") \|\| text.startsWith("."))) {`
	`84`	`+ if (text.startsWith("\n") \|\| text.startsWith(".")) {`
`85`	`85`	`throw new IgnoreMeException();`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`if (rightExpected.isString()) {`
`90`	`90`	`String text = rightExpected.castAsString();`
`91`		`- while ((text.startsWith(" ") \|\| text.startsWith("\t")) && !text.isEmpty()) {`
	`91`	`+ while (text.startsWith(" ") \|\| text.startsWith("\t")) {`
`92`	`92`	`text = text.substring(1);`
`93`	`93`	`}`
`94`		`- if (!text.isEmpty() && (text.startsWith("\n") \|\| text.startsWith("."))) {`
	`94`	`+ if (text.startsWith("\n") \|\| text.startsWith(".")) {`
`95`	`95`	`throw new IgnoreMeException();`
`96`	`96`	`}`
`97`	`97`	`}`