Fix custom type saving when only focus changes for user-entered type #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment when user types a custom type into the type combo box and doesn't press enter, the entered type isn't used. This patch tries to fix the problem by installing an event filter for the combo box and checking when it loses focus - when it does, it performs type updates too. On the way the patch also changes the signal used inside moveCurrentField() from activated() to currentIndexChanged() to make it consistent with the rest of the file.
|
To workaround the missing "focus out" signal I found this: and using the event filter seemed to be the easiest way. |
|
Awesome @techee, looks like a win. @MKleusberg will probably review this sometime today, and merge it if good. 😄 |
|
@MKleusberg I haven't created the 3.10.1 release yet. Is this something which should go in it? |
|
Awesome, @techee! 👍 I can't see any problem with this. Thanks a lot 😄 If you ever feel like opening another PR you're very welcome to do so. @justinclift Sure, why not. I'll backport it in a second. |
|
@justinclift Done 😄 |
|
@MKleusberg Awesome, thanks. 😄 I'll into the release process shortly. A bit behind schedule, but it'll still probably be today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment when user types a custom type into the type combo box and
doesn't press enter, the entered type isn't used. This patch tries to fix
the problem by installing an event filter for the combo box and checking
when it loses focus - when it does, it performs type updates too.
On the way the patch also changes the signal used inside moveCurrentField()
from activated() to currentIndexChanged() to make it consistent with the
rest of the file.
Fixes #1144.