fix: UTF-8 characters (when out of comments or quotes) are drawn with different font #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @SevenLines, that's excellent. 😀 @MKleusberg is this good to merge? |
|
@MKleusberg ping? |
|
I'm just going to merge this and hope for the best. If it breaks things for people, I'm sure someone will file an issue. 😄 |
justinclift
added a commit
that referenced
this pull request
Jul 1, 2015
fix: UTF-8 characters (when out of comments or quotes) are drawn with different font
|
Should be fine. I still think there's some bug in QScintilla because I see no other reasons why the middle part of the first line in the first picture of the original issue is highlighted differently. But at least we're now working successfully around it 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function
setFont(), without params, sets font for all lexems types. .To set default font color to black I used
sqlLexer->setColor(Qt::black, QsciLexerSQL::Default).That's also keeps numbers color with aquablue color
And it doesn't looks very clever now, it thinks that every not special english SQL word is table or column name.
I compared it with old (before Scintilla) appearance: