Fix sqlcipher and OSX 10.10 build. #384
Conversation
Building under Mac OS X 10.10 was broken using latest QT SDK. Add missing macextras and fix INCLUDEPATH for mac.
|
Ahhhh interesting. I haven't tried OSX 10.10 at all yet. I'll try to get it running in a VM later on today, verify this, then merge it. 😄 |
|
(Sorry for the delay btw, have been unwell for a few days) |
| INCLUDEPATH += -I/usr/local/include \ | ||
| -I/usr/local/opt/sqlite/include | ||
| QT+= macextras | ||
| INCLUDEPATH += /usr/local/include \ |
There was a problem hiding this comment.
Hmmm, this may have been why I wasn't able to build with SQLCipher support on OSX 10.9 a while ago (but didn't bother looking into it :/).
There was a problem hiding this comment.
Without this patch you will get a '-I-I' in the compiler command. That's why the SQLCipher build broke.
There was a problem hiding this comment.
Yeah, that's what I remember seeing. 😉
I've just installed Yosemite in a VM, so am going through getting Homebrew functional so I can test this.
|
Yep, working well here on OSX 10.10. The existing codebase (without this patch) barfs. |
Fix sqlcipher and OSX 10.10 build.
|
Thanks @jehoffmann! 😀 |
Building under Mac OS X 10.10 was broken using QT SDK 5.4. Add
missing macextras.
To be able to build against sqlcipher fix INCLUDEPATH for mac by removing the -I from PATH.