Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the train_test_split parts in pipelines #91

Open
stavrostheocharis opened this issue Jan 5, 2023 · 5 comments · May be fixed by #157
Open

Adjust the train_test_split parts in pipelines #91

stavrostheocharis opened this issue Jan 5, 2023 · 5 comments · May be fixed by #157
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@stavrostheocharis
Copy link
Contributor

We use "train_test_split" in "src/analytics/models/pipelines" at lines 40 & 98. In case that after the splitting only one class remains at the train set, an error will follow based on the next calculations (AUC ROC, etc.).

Need to adjust the train_test_split parts and possibly use the "stratify" argument as described inside the docs: https://scikit-learn.org/stable/modules/generated/sklearn.model_selection.train_test_split.html

@stavrostheocharis stavrostheocharis added the bug Something isn't working label Jan 5, 2023
@momegas momegas moved this from Todo to Backlog in 🐻‍❄️ Whitebox - Issue tracking Feb 15, 2023
@momegas momegas changed the title Train test split Adjust the train_test_split parts in pipelines Feb 15, 2023
@momegas momegas added the good first issue Good for newcomers label Feb 15, 2023
@aditkay95
Copy link

I am willing to work on this as my first issue @stavrostheocharis @momegas

@momegas
Copy link
Member

momegas commented Feb 17, 2023

Feel free to open a PR. I assign this to you as well.

@momegas
Copy link
Member

momegas commented Feb 28, 2023

Hey @aditkay95 please tell me when to move to in progress when you start working on it

@Mikehade
Copy link

Mikehade commented Mar 14, 2023

I would like to work on this issue @momegas and @stavrostheocharis

@momegas
Copy link
Member

momegas commented Mar 15, 2023

Im assining this to you

@Mikehade Mikehade linked a pull request Mar 15, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy