refactor: dashboard api base url env (#374)

peppescg · web-flow · commit 0f6eca4644c0 · 2025-03-05T15:25:05.000+01:00
diff --git a/index.html b/index.html
@@ -9,7 +9,7 @@
     <div id="root"></div>
     <script>
       window.APP_CONFIG = {
-        BASE_API_URL: '${BASE_API_URL}',
+        DASHBOARD_API_BASE_URL: '${DASHBOARD_API_BASE_URL}',
       }
     </script>
     <script type="module" src="/src/main.tsx"></script>
diff --git a/src/global.d.ts b/src/global.d.ts
@@ -1,5 +1,5 @@
 export interface AppConfig {
-  BASE_API_URL?: string
+  DASHBOARD_API_BASE_URL?: string
 }
 
 declare global {
diff --git a/src/hooks/useSse.ts b/src/hooks/useSse.ts
@@ -8,7 +8,7 @@ import {
 import { invalidateQueries } from '@/lib/react-query-utils'
 import { getAppConfig } from '@/lib/utils'
 
-const baseApiUrl = getAppConfig().BASE_API_URL
+const baseApiUrl = getAppConfig().DASHBOARD_API_BASE_URL
 
 export function useSse() {
   const location = useLocation()
diff --git a/src/lib/__tests__/utils.test.ts b/src/lib/__tests__/utils.test.ts
@@ -4,9 +4,9 @@ import { AppConfig } from '@/global'
 describe('getAppConfig', () => {
   const mockViteBaseApiUrl = 'https://api.mock.com'
 
-  it('default base api url if ${BASE_API_URL}" not configured', () => {
+  it('default base api url if ${DASHBOARD_API_BASE_URL}" not configured', () => {
     const mockAppConfig: AppConfig = {
-      BASE_API_URL: '${BASE_API_URL}',
+      DASHBOARD_API_BASE_URL: '${DASHBOARD_API_BASE_URL}',
     }
 
     Object.defineProperty(window, 'APP_CONFIG', {
@@ -16,15 +16,15 @@ describe('getAppConfig', () => {
 
     const expectedConfig: AppConfig = {
       ...mockAppConfig,
-      BASE_API_URL: 'https://mock.codegate.ai',
+      DASHBOARD_API_BASE_URL: 'https://mock.codegate.ai',
     }
 
     expect(getAppConfig()).toEqual(expectedConfig)
   })
 
-  it('replace base api url if ${BASE_API_URL}" is configured', () => {
+  it('replace base api url if ${DASHBOARD_API_BASE_URL}" is configured', () => {
     const mockAppConfig: AppConfig = {
-      BASE_API_URL: mockViteBaseApiUrl,
+      DASHBOARD_API_BASE_URL: mockViteBaseApiUrl,
     }
 
     Object.defineProperty(window, 'APP_CONFIG', {
@@ -34,7 +34,7 @@ describe('getAppConfig', () => {
 
     const expectedConfig: AppConfig = {
       ...mockAppConfig,
-      BASE_API_URL: mockViteBaseApiUrl,
+      DASHBOARD_API_BASE_URL: mockViteBaseApiUrl,
     }
 
     expect(getAppConfig()).toEqual(expectedConfig)
diff --git a/src/lib/utils.ts b/src/lib/utils.ts
@@ -73,17 +73,17 @@ export function sanitizeQuestionPrompt({
 }
 
 export function getAppConfig(): AppConfig {
-  const baseApiUrl = window.APP_CONFIG?.BASE_API_URL
+  const baseApiUrl = window.APP_CONFIG?.DASHBOARD_API_BASE_URL
 
-  if (!baseApiUrl || baseApiUrl === '${BASE_API_URL}') {
+  if (!baseApiUrl || baseApiUrl === '${DASHBOARD_API_BASE_URL}') {
     return {
       ...window.APP_CONFIG,
-      BASE_API_URL: import.meta.env.VITE_BASE_API_URL,
+      DASHBOARD_API_BASE_URL: import.meta.env.VITE_BASE_API_URL,
     }
   }
 
   return {
     ...window.APP_CONFIG,
-    BASE_API_URL: baseApiUrl,
+    DASHBOARD_API_BASE_URL: baseApiUrl,
   }
 }
diff --git a/src/main.tsx b/src/main.tsx
@@ -17,7 +17,7 @@ import { getAppConfig } from './lib/utils.ts'
 
 // Initialize the API client
 client.setConfig({
-  baseUrl: getAppConfig().BASE_API_URL,
+  baseUrl: getAppConfig().DASHBOARD_API_BASE_URL,
 })
 
 createRoot(document.getElementById('root')!).render(
diff --git a/src/vite-env.d.ts b/src/vite-env.d.ts
@@ -1,5 +1,5 @@
 /// <reference types="vite/client" />
 interface ImportBaseApiEnv {
-  readonly BASE_API_URL: string
+  readonly DASHBOARD_API_BASE_URL: string
   readonly VITE_BASE_API_URL: string
 }

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`<div id="root"></div>`
`10`	`10`	`<script>`
`11`	`11`	`window.APP_CONFIG = {`
`12`		`- BASE_API_URL: '${BASE_API_URL}',`
	`12`	`+ DASHBOARD_API_BASE_URL: '${DASHBOARD_API_BASE_URL}',`
`13`	`13`	`}`
`14`	`14`	`</script>`
`15`	`15`	`<script type="module" src="/src/main.tsx"></script>`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`export interface AppConfig {`
`2`		`- BASE_API_URL?: string`
	`2`	`+ DASHBOARD_API_BASE_URL?: string`
`3`	`3`	`}`
`4`	`4`
`5`	`5`	`declare global {`
Original file line number	Diff line number	Diff line change
`@@ -73,17 +73,17 @@ export function sanitizeQuestionPrompt({`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`export function getAppConfig(): AppConfig {`
`76`		`- const baseApiUrl = window.APP_CONFIG?.BASE_API_URL`
	`76`	`+ const baseApiUrl = window.APP_CONFIG?.DASHBOARD_API_BASE_URL`
`77`	`77`
`78`		`- if (!baseApiUrl \|\| baseApiUrl === '${BASE_API_URL}') {`
	`78`	`+ if (!baseApiUrl \|\| baseApiUrl === '${DASHBOARD_API_BASE_URL}') {`
`79`	`79`	`return {`
`80`	`80`	`...window.APP_CONFIG,`
`81`		`- BASE_API_URL: import.meta.env.VITE_BASE_API_URL,`
	`81`	`+ DASHBOARD_API_BASE_URL: import.meta.env.VITE_BASE_API_URL,`
`82`	`82`	`}`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`return {`
`86`	`86`	`...window.APP_CONFIG,`
`87`		`- BASE_API_URL: baseApiUrl,`
	`87`	`+ DASHBOARD_API_BASE_URL: baseApiUrl,`
`88`	`88`	`}`
`89`	`89`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/// <reference types="vite/client" />`
`2`	`2`	`interface ImportBaseApiEnv {`
`3`		`- readonly BASE_API_URL: string`
	`3`	`+ readonly DASHBOARD_API_BASE_URL: string`
`4`	`4`	`readonly VITE_BASE_API_URL: string`
`5`	`5`	`}`