From 9eb2021cf45f97f1e6588d56d6bdfdc43ba10442 Mon Sep 17 00:00:00 2001 From: Daniel Kantor Date: Wed, 15 Jan 2025 14:44:34 +0100 Subject: [PATCH 1/5] refactor: extract --- src/components/Header.tsx | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/components/Header.tsx b/src/components/Header.tsx index 33115d7c..3d304518 100644 --- a/src/components/Header.tsx +++ b/src/components/Header.tsx @@ -2,6 +2,14 @@ import { Link } from "react-router-dom"; import { SidebarTrigger } from "./ui/sidebar"; import { Separator } from "./ui/separator"; +function HeaderMenuItem({ children }: { children: React.ReactNode }) { + return ( +
+ {children} +
+ ); +} + export function Header({ hasError }: { hasError?: boolean }) { return (
@@ -23,9 +31,7 @@ export function Header({ hasError }: { hasError?: boolean }) {
-
- Certificates -
+ Certificates
-
- Help -
+ Help
Date: Wed, 15 Jan 2025 14:48:06 +0100 Subject: [PATCH 2/5] refactor: extract --- src/components/Header.tsx | 69 +++++++++++++++++++++------------------ 1 file changed, 37 insertions(+), 32 deletions(-) diff --git a/src/components/Header.tsx b/src/components/Header.tsx index 3d304518..dc991be1 100644 --- a/src/components/Header.tsx +++ b/src/components/Header.tsx @@ -10,6 +10,14 @@ function HeaderMenuItem({ children }: { children: React.ReactNode }) { ); } +function DropdownMenu({ children }: { children: React.ReactNode }) { + return ( +
+
{children}
+
+ ); +} + export function Header({ hasError }: { hasError?: boolean }) { return (
@@ -32,41 +40,38 @@ export function Header({ hasError }: { hasError?: boolean }) {
Certificates -
-
- - Download - - - Certificate Security - -
-
+ + + Download + + + Certificate Security + +
Help -
-
- - Continue Setup - - - Copilot Setup - -
-
+ + + + Continue Setup + + + Copilot Setup + +
From b610317b6d7a9dceca73c2150b54435c7cff9334 Mon Sep 17 00:00:00 2001 From: Daniel Kantor Date: Wed, 15 Jan 2025 14:50:49 +0100 Subject: [PATCH 3/5] refactor: extract --- src/components/Header.tsx | 42 +++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/src/components/Header.tsx b/src/components/Header.tsx index dc991be1..af0f3c82 100644 --- a/src/components/Header.tsx +++ b/src/components/Header.tsx @@ -18,6 +18,20 @@ function DropdownMenu({ children }: { children: React.ReactNode }) { ); } +function DropdownMenuItem({ + children, + to, +}: { + to: string; + children: React.ReactNode; +}) { + return ( + + {children} + + ); +} + export function Header({ hasError }: { hasError?: boolean }) { return (
@@ -41,36 +55,22 @@ export function Header({ hasError }: { hasError?: boolean }) {
Certificates - - Download - - + Download + Certificate Security - +
Help - + Continue Setup - - + + Copilot Setup - +
From 55b07458581b09aae7f8d016e4529a74e2e5f7ad Mon Sep 17 00:00:00 2001 From: Daniel Kantor Date: Wed, 15 Jan 2025 15:01:35 +0100 Subject: [PATCH 4/5] chore: add prettier --- package-lock.json | 16 ++++++++++++++++ package.json | 1 + src/components/Header.tsx | 2 +- 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index 22d5acd7..123653ce 100644 --- a/package-lock.json +++ b/package-lock.json @@ -61,6 +61,7 @@ "lint-staged": "^15.3.0", "msw": "^2.7.0", "postcss": "^8.4.49", + "prettier": "3.4.2", "tailwindcss": "^3.4.15", "typescript": "~5.7.2", "typescript-eslint": "^8.15.0", @@ -8135,6 +8136,21 @@ "node": ">= 0.8.0" } }, + "node_modules/prettier": { + "version": "3.4.2", + "resolved": "https://registry.npmjs.org/prettier/-/prettier-3.4.2.tgz", + "integrity": "sha512-e9MewbtFo+Fevyuxn/4rrcDAaq0IYxPGLvObpQjiZBMAzB9IGmzlnG9RZy3FFas+eBMu2vA0CszMeduow5dIuQ==", + "dev": true, + "bin": { + "prettier": "bin/prettier.cjs" + }, + "engines": { + "node": ">=14" + }, + "funding": { + "url": "https://github.com/prettier/prettier?sponsor=1" + } + }, "node_modules/pretty-format": { "version": "27.5.1", "resolved": "https://registry.npmjs.org/pretty-format/-/pretty-format-27.5.1.tgz", diff --git a/package.json b/package.json index 7489e50f..a0d0c835 100644 --- a/package.json +++ b/package.json @@ -71,6 +71,7 @@ "lint-staged": "^15.3.0", "msw": "^2.7.0", "postcss": "^8.4.49", + "prettier": "3.4.2", "tailwindcss": "^3.4.15", "typescript": "~5.7.2", "typescript-eslint": "^8.15.0", diff --git a/src/components/Header.tsx b/src/components/Header.tsx index af0f3c82..b8c56a55 100644 --- a/src/components/Header.tsx +++ b/src/components/Header.tsx @@ -61,9 +61,9 @@ export function Header({ hasError }: { hasError?: boolean }) {
+
Help - Continue Setup From e4840e68a119b09b90179e59662b2dd789ac5551 Mon Sep 17 00:00:00 2001 From: Daniel Kantor Date: Wed, 15 Jan 2025 15:58:33 +0100 Subject: [PATCH 5/5] feat: make "setup" menu section less confusing --- src/components/Header.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/Header.tsx b/src/components/Header.tsx index b8c56a55..20884c10 100644 --- a/src/components/Header.tsx +++ b/src/components/Header.tsx @@ -63,13 +63,13 @@ export function Header({ hasError }: { hasError?: boolean }) {
- Help + Setup - Continue Setup + Set up in Continue - Copilot Setup + Set up in Copilot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy