Skip to content

Run check on all addons test #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brettearle
Copy link
Contributor

@brettearle brettearle commented May 19, 2025

closes: #344

blocked by upstream pr on story book

Edit: storybookjs/storybook#31451

Copy link

changeset-bot bot commented May 19, 2025

⚠️ No Changeset found

Latest commit: a1d8bdb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented May 19, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@569
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@569

commit: a1d8bdb

@brettearle brettearle marked this pull request as draft May 19, 2025 14:43
@brettearle
Copy link
Contributor Author

brettearle commented May 19, 2025

@manuel3108 this is the prototype for making check pass in all addons

Edit: Wont need the tooling comment change

Edit: The paraglide and Lucia hook are different. Would need to update paraglide to magic string implementation to match them. Running parseScript removes jsdoc comments from previous run. In this case paraglide comments were getting overridden when Lucia hook.server ran with ast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run check command on all-addon test
1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy