bug #47242 [DoctrineBridge] Do not ignore null IDs in EntityValueResolver (MatTheCat)

nicolas-grekas · nicolas-grekas · commit 119e7d0defc4 · 2022-08-18T16:36:44.000+02:00
This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [DoctrineBridge] Do not ignore null IDs in EntityValueResolver | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #47166 | License | MIT | Doc PR | N/A The `EntityValueResolver` first try to fetch an entity by its ID but handle null and non-existent IDs the same. If a `null` ID is present, it feels weird to ignore it and try matching an entity using other request attributes. Better return `null` in this case. Commits ------- db05d4c [DoctrineBridge] Do not ignore null IDs in EntityValueResolver
diff --git a/src/Symfony/Bridge/Doctrine/ArgumentResolver/EntityValueResolver.php b/src/Symfony/Bridge/Doctrine/ArgumentResolver/EntityValueResolver.php
@@ -74,7 +74,7 @@ public function resolve(Request $request, ArgumentMetadata $argument): iterable
             if (null === $object = $this->findViaExpression($class, $request, $options->expr, $options)) {
                 $errorMessage = sprintf('The expression "%s" returned null', $options->expr);
             }
-            // find by identifier?
+        // find by identifier?
         } elseif (false === $object = $this->find($class, $request, $options, $name)) {
             // find by criteria
             if (false === $object = $this->findOneBy($class, $request, $options)) {
@@ -123,7 +123,7 @@ private function find(string $class, Request $request, MapEntity $options, strin
 
         $id = $this->getIdentifier($request, $options, $name);
         if (false === $id || null === $id) {
-            return false;
+            return $id;
         }
 
         $objectManager = $this->getManager($options->objectManager, $class);
diff --git a/src/Symfony/Bridge/Doctrine/Tests/ArgumentResolver/EntityValueResolverTest.php b/src/Symfony/Bridge/Doctrine/Tests/ArgumentResolver/EntityValueResolverTest.php
@@ -1,5 +1,14 @@
 <?php
 
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 namespace Symfony\Bridge\Doctrine\Tests\ArgumentResolver;
 
 use Doctrine\DBAL\Types\ConversionException;
@@ -214,6 +223,21 @@ public function testApplyWithId(string|int $id)
         $this->assertYieldEquals([$object], $ret);
     }
 
+    public function testApplyWithNullId()
+    {
+        $registry = $this->getMockBuilder(ManagerRegistry::class)->getMock();
+        $converter = new EntityValueResolver($registry);
+
+        $request = new Request();
+        $request->attributes->set('id', null);
+
+        $argument = $this->createArgument(isNullable: true);
+
+        $ret = $converter->resolve($request, $argument);
+
+        $this->assertYieldEquals([null], $ret);
+    }
+
     public function testApplyWithConversionFailedException()
     {
         $registry = $this->getMockBuilder(ManagerRegistry::class)->getMock();
@@ -276,7 +300,7 @@ public function testApplyGuessOptional()
         $converter = new EntityValueResolver($registry);
 
         $request = new Request();
-        $request->attributes->set('arg', null);
+        $request->attributes->set('guess', null);
 
         $argument = $this->createArgument('stdClass', new MapEntity(), 'arg', true);
 
