Issue reproducer

Wirone · Wirone · commit 594cdf655a64 · 2025-03-14T15:51:58.000+01:00
See: https://x.com/_Codito_/status/1900523413204013096
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckTypeDeclarationsPassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckTypeDeclarationsPassTest.php
@@ -20,6 +20,7 @@
 use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
 use Symfony\Component\DependencyInjection\Exception\InvalidParameterTypeException;
+use Symfony\Component\DependencyInjection\Parameter;
 use Symfony\Component\DependencyInjection\ParameterBag\EnvPlaceholderParameterBag;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass\Bar;
@@ -28,6 +29,8 @@
 use Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass\BarOptionalArgument;
 use Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass\BarOptionalArgumentNotNull;
 use Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass\Deprecated;
+use Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass\ExpectsIntegerArgument;
+use Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass\ExpectsIntegerArgumentWrapper;
 use Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass\Foo;
 use Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass\FooObject;
 use Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass\IntersectionConstructor;
@@ -642,6 +645,27 @@ public function testProcessSuccessWhenExpressionReturnsObject()
         $this->addToAssertionCount(1);
     }
 
+    public function testErrorOnEvaluatingExpressionDoesNotStopTheProcess()
+    {
+        $container = new ContainerBuilder(new EnvPlaceholderParameterBag([
+            'some_int' => '%env(SOME_INT)%',
+        ]));
+
+        $container
+            ->register('eia', ExpectsIntegerArgument::class)
+            ->setPublic(true)
+            ->setShared(false)
+            ->setFactory([ExpectsIntegerArgument::class, 'create'])
+            ->addArgument(new Parameter('some_int'));
+        $container
+            ->register('eia_wrapper', ExpectsIntegerArgumentWrapper::class)
+            ->addArgument(new Expression('service("eia").instance()'));
+
+        (new CheckTypeDeclarationsPass(true))->process($container);
+
+        $this->addToAssertionCount(1);
+    }
+
     public function testProcessHandleMixedEnvPlaceholder()
     {
         $container = new ContainerBuilder(new EnvPlaceholderParameterBag([
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/ExpectsIntegerArgument.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/ExpectsIntegerArgument.php
@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass;
+
+final readonly class ExpectsIntegerArgument
+{
+    public function __construct(public int $foo) {}
+
+    public static function create(int $foo): self
+    {
+        return new self($foo);
+    }
+
+    public function instance(): self {
+        return $this;
+    }
+}
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/ExpectsIntegerArgumentWrapper.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeDeclarationsPass/ExpectsIntegerArgumentWrapper.php
@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeDeclarationsPass;
+
+final readonly class ExpectsIntegerArgumentWrapper
+{
+    public function __construct(public ExpectsIntegerArgument $b) {}
+}
