minor #57559 [Serializer] Check if exception message in test is correct (HypeMC)

nicolas-grekas · nicolas-grekas · commit 7fcb72b56299 · 2024-06-28T09:27:43.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Check if exception message in test is correct | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #57427 (just test) | License | MIT This is a test for #57433 Commits ------- 2fc8789 [Serializer] Check if exception message in test is correct
diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/NotNormalizableDummy.php b/src/Symfony/Component/Serializer/Tests/Fixtures/NotNormalizableDummy.php
@@ -26,6 +26,6 @@ public function __construct()
 
     public function denormalize(DenormalizerInterface $denormalizer, $data, ?string $format = null, array $context = [])
     {
-        throw new NotNormalizableValueException();
+        throw new NotNormalizableValueException('Custom exception message');
     }
 }
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
@@ -514,6 +514,7 @@ public function testDenormalizeUntypedFormat()
     public function testDenormalizeUntypedFormatNotNormalizable()
     {
         $this->expectException(NotNormalizableValueException::class);
+        $this->expectExceptionMessage('Custom exception message');
         $serializer = new Serializer([new CustomNormalizer(), new ObjectNormalizer(null, null, null, new PropertyInfoExtractor([], [new PhpDocExtractor(), new ReflectionExtractor()]))]);
         $serializer->denormalize(['value' => 'test'], DummyWithNotNormalizable::class, 'xml');
     }

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,6 @@ public function __construct()`
`26`	`26`
`27`	`27`	`public function denormalize(DenormalizerInterface $denormalizer, $data, ?string $format = null, array $context = [])`
`28`	`28`	`{`
`29`		`- throw new NotNormalizableValueException();`
	`29`	`+ throw new NotNormalizableValueException('Custom exception message');`
`30`	`30`	`}`
`31`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -514,6 +514,7 @@ public function testDenormalizeUntypedFormat()`
`514`	`514`	`public function testDenormalizeUntypedFormatNotNormalizable()`
`515`	`515`	`{`
`516`	`516`	`$this->expectException(NotNormalizableValueException::class);`
	`517`	`+ $this->expectExceptionMessage('Custom exception message');`
`517`	`518`	`$serializer = new Serializer([new CustomNormalizer(), new ObjectNormalizer(null, null, null, new PropertyInfoExtractor([], [new PhpDocExtractor(), new ReflectionExtractor()]))]);`
`518`	`519`	`$serializer->denormalize(['value' => 'test'], DummyWithNotNormalizable::class, 'xml');`
`519`	`520`	`}`