bug #59399 [DomCrawler] Make ChoiceFormField::isDisabled return true for unchecked disabled checkboxes (MatTheCat)

nicolas-grekas · nicolas-grekas · commit cb5fdafebcb6 · 2025-01-22T15:32:42.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [DomCrawler] Make `ChoiceFormField::isDisabled` return `true` for unchecked disabled checkboxes | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #8348 | License | MIT `ChoiceFormField::isDisabled`’s PHPDoc reads > Check if the current selected option is disabled. But a checkbox really embeds two options: either you check it, or not; which means it always has a selected option. Then, if a checkbox is disabled, these two options are too. So, `ChoiceFormField::isDisabled` should return `true` for disabled checkboxes, checked or not. This also matches what you intuitively would expect from this method. Commits ------- 9807ce6 [DomCrawler] Make `ChoiceFormField::isDisabled` return `true` for unchecked disabled checkboxes
diff --git a/src/Symfony/Component/DomCrawler/Field/ChoiceFormField.php b/src/Symfony/Component/DomCrawler/Field/ChoiceFormField.php
@@ -45,6 +45,10 @@ public function hasValue(): bool
      */
     public function isDisabled(): bool
     {
+        if ('checkbox' === $this->type) {
+            return parent::isDisabled();
+        }
+
         if (parent::isDisabled() && 'select' === $this->type) {
             return true;
         }
diff --git a/src/Symfony/Component/DomCrawler/Tests/Field/ChoiceFormFieldTest.php b/src/Symfony/Component/DomCrawler/Tests/Field/ChoiceFormFieldTest.php
@@ -272,6 +272,17 @@ public function testCheckboxWithEmptyBooleanAttribute()
         $this->assertEquals('foo', $field->getValue());
     }
 
+    public function testCheckboxIsDisabled()
+    {
+        $node = $this->createNode('input', '', ['type' => 'checkbox', 'name' => 'name', 'disabled' => '']);
+        $field = new ChoiceFormField($node);
+
+        $this->assertTrue($field->isDisabled(), '->isDisabled() returns true when the checkbox is disabled, even if it is not checked');
+
+        $field->tick();
+        $this->assertTrue($field->isDisabled(), '->isDisabled() returns true when the checkbox is disabled, even if it is checked');
+    }
+
     public function testTick()
     {
         $node = $this->createSelectNode(['foo' => false, 'bar' => false]);

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,10 @@ public function hasValue(): bool`
`45`	`45`	`*/`
`46`	`46`	`public function isDisabled(): bool`
`47`	`47`	`{`
	`48`	`+ if ('checkbox' === $this->type) {`
	`49`	`+ return parent::isDisabled();`
	`50`	`+ }`
	`51`	`+`
`48`	`52`	`if (parent::isDisabled() && 'select' === $this->type) {`
`49`	`53`	`return true;`
`50`	`54`	`}`