Fix implicitly-required parameters

nicolas-grekas · nicolas-grekas · commit fb9fa2610251 · 2024-01-23T15:28:09.000+01:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/Bundle/TestBundle/AutowiringTypes/AutowiredServices.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/Bundle/TestBundle/AutowiringTypes/AutowiredServices.php
@@ -21,7 +21,7 @@ class AutowiredServices
     private $dispatcher;
     private $cachePool;
 
-    public function __construct(?Reader $annotationReader = null, EventDispatcherInterface $dispatcher, CacheItemPoolInterface $cachePool)
+    public function __construct(?Reader $annotationReader, EventDispatcherInterface $dispatcher, CacheItemPoolInterface $cachePool)
     {
         $this->annotationReader = $annotationReader;
         $this->dispatcher = $dispatcher;
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php b/src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php
@@ -40,7 +40,7 @@ class ProfilerController
     private $cspHandler;
     private $baseDir;
 
-    public function __construct(UrlGeneratorInterface $generator, ?Profiler $profiler = null, Environment $twig, array $templates, ?ContentSecurityPolicyHandler $cspHandler = null, ?string $baseDir = null)
+    public function __construct(UrlGeneratorInterface $generator, ?Profiler $profiler, Environment $twig, array $templates, ?ContentSecurityPolicyHandler $cspHandler = null, ?string $baseDir = null)
     {
         $this->generator = $generator;
         $this->profiler = $profiler;
diff --git a/src/Symfony/Component/Console/Tests/CI/GithubActionReporterTest.php b/src/Symfony/Component/Console/Tests/CI/GithubActionReporterTest.php
@@ -34,7 +34,7 @@ public function testIsGithubActionEnvironment()
     /**
      * @dataProvider annotationsFormatProvider
      */
-    public function testAnnotationsFormat(string $type, string $message, ?string $file = null, ?int $line = null, ?int $col = null, string $expected)
+    public function testAnnotationsFormat(string $type, string $message, ?string $file, ?int $line, ?int $col, string $expected)
     {
         $reporter = new GithubActionReporter($buffer = new BufferedOutput());
 
diff --git a/src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php b/src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php
@@ -298,7 +298,7 @@ private function &recursiveBuildPreliminaryFormTree(FormInterface $form, array &
         return $output;
     }
 
-    private function &recursiveBuildFinalFormTree(?FormInterface $form = null, FormView $view, array &$outputByHash)
+    private function &recursiveBuildFinalFormTree(?FormInterface $form, FormView $view, array &$outputByHash)
     {
         $viewHash = spl_object_hash($view);
         $formHash = null;
diff --git a/src/Symfony/Component/HttpKernel/Fragment/AbstractSurrogateFragmentRenderer.php b/src/Symfony/Component/HttpKernel/Fragment/AbstractSurrogateFragmentRenderer.php
@@ -34,7 +34,7 @@ abstract class AbstractSurrogateFragmentRenderer extends RoutableFragmentRendere
      *
      * @param FragmentRendererInterface $inlineStrategy The inline strategy to use when the surrogate is not supported
      */
-    public function __construct(?SurrogateInterface $surrogate = null, FragmentRendererInterface $inlineStrategy, ?UriSigner $signer = null)
+    public function __construct(?SurrogateInterface $surrogate, FragmentRendererInterface $inlineStrategy, ?UriSigner $signer = null)
     {
         $this->surrogate = $surrogate;
         $this->inlineStrategy = $inlineStrategy;
diff --git a/src/Symfony/Component/HttpKernel/Tests/DependencyInjection/RegisterControllerArgumentLocatorsPassTest.php b/src/Symfony/Component/HttpKernel/Tests/DependencyInjection/RegisterControllerArgumentLocatorsPassTest.php
@@ -512,7 +512,7 @@ public function fooAction(?NonExistentClass $nonExistent = null)
     {
     }
 
-    public function barAction(?NonExistentClass $nonExistent = null, $bar)
+    public function barAction(?NonExistentClass $nonExistent, $bar)
     {
     }
 }
diff --git a/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpDocExtractorTest.php b/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpDocExtractorTest.php
@@ -157,7 +157,7 @@ public static function typesProvider()
     /**
      * @dataProvider provideCollectionTypes
      */
-    public function testExtractCollection($property, ?array $type = null, $shortDescription, $longDescription)
+    public function testExtractCollection($property, ?array $type, $shortDescription, $longDescription)
     {
         if (!class_exists(Collection::class)) {
             $this->markTestSkipped('Collections are not implemented in current phpdocumentor/type-resolver version');
diff --git a/src/Symfony/Component/Validator/Context/ExecutionContext.php b/src/Symfony/Component/Validator/Context/ExecutionContext.php
@@ -152,7 +152,7 @@ public function __construct(ValidatorInterface $validator, $root, TranslatorInte
     /**
      * {@inheritdoc}
      */
-    public function setNode($value, ?object $object, ?MetadataInterface $metadata = null, string $propertyPath)
+    public function setNode($value, ?object $object, ?MetadataInterface $metadata, string $propertyPath)
     {
         $this->value = $value;
         $this->object = $object;
diff --git a/src/Symfony/Component/Validator/Context/ExecutionContextInterface.php b/src/Symfony/Component/Validator/Context/ExecutionContextInterface.php
@@ -129,7 +129,7 @@ public function getObject();
      * @param object|null $object       The currently validated object
      * @param string      $propertyPath The property path to the current value
      */
-    public function setNode($value, ?object $object, ?MetadataInterface $metadata = null, string $propertyPath);
+    public function setNode($value, ?object $object, ?MetadataInterface $metadata, string $propertyPath);
 
     /**
      * Warning: Should not be called by user code, to be used by the validator engine only.
diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php
@@ -727,6 +727,6 @@ public static function stub(): void
     }
 }
 
-function reflectionParameterFixture(?NotLoadableClass $arg1 = null, $arg2)
+function reflectionParameterFixture(?NotLoadableClass $arg1, $arg2)
 {
 }

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class AutowiredServices`
`21`	`21`	`private $dispatcher;`
`22`	`22`	`private $cachePool;`
`23`	`23`
`24`		`- public function __construct(?Reader $annotationReader = null, EventDispatcherInterface $dispatcher, CacheItemPoolInterface $cachePool)`
	`24`	`+ public function __construct(?Reader $annotationReader, EventDispatcherInterface $dispatcher, CacheItemPoolInterface $cachePool)`
`25`	`25`	`{`
`26`	`26`	`$this->annotationReader = $annotationReader;`
`27`	`27`	`$this->dispatcher = $dispatcher;`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ class ProfilerController`
`40`	`40`	`private $cspHandler;`
`41`	`41`	`private $baseDir;`
`42`	`42`
`43`		`- public function __construct(UrlGeneratorInterface $generator, ?Profiler $profiler = null, Environment $twig, array $templates, ?ContentSecurityPolicyHandler $cspHandler = null, ?string $baseDir = null)`
	`43`	`+ public function __construct(UrlGeneratorInterface $generator, ?Profiler $profiler, Environment $twig, array $templates, ?ContentSecurityPolicyHandler $cspHandler = null, ?string $baseDir = null)`
`44`	`44`	`{`
`45`	`45`	`$this->generator = $generator;`
`46`	`46`	`$this->profiler = $profiler;`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function testIsGithubActionEnvironment()`
`34`	`34`	`/**`
`35`	`35`	`* @dataProvider annotationsFormatProvider`
`36`	`36`	`*/`
`37`		`- public function testAnnotationsFormat(string $type, string $message, ?string $file = null, ?int $line = null, ?int $col = null, string $expected)`
	`37`	`+ public function testAnnotationsFormat(string $type, string $message, ?string $file, ?int $line, ?int $col, string $expected)`
`38`	`38`	`{`
`39`	`39`	`$reporter = new GithubActionReporter($buffer = new BufferedOutput());`
`40`	`40`
Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,7 @@ private function &recursiveBuildPreliminaryFormTree(FormInterface $form, array &`
`298`	`298`	`return $output;`
`299`	`299`	`}`
`300`	`300`
`301`		`- private function &recursiveBuildFinalFormTree(?FormInterface $form = null, FormView $view, array &$outputByHash)`
	`301`	`+ private function &recursiveBuildFinalFormTree(?FormInterface $form, FormView $view, array &$outputByHash)`
`302`	`302`	`{`
`303`	`303`	`$viewHash = spl_object_hash($view);`
`304`	`304`	`$formHash = null;`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ abstract class AbstractSurrogateFragmentRenderer extends RoutableFragmentRendere`
`34`	`34`	`*`
`35`	`35`	`* @param FragmentRendererInterface $inlineStrategy The inline strategy to use when the surrogate is not supported`
`36`	`36`	`*/`
`37`		`- public function __construct(?SurrogateInterface $surrogate = null, FragmentRendererInterface $inlineStrategy, ?UriSigner $signer = null)`
	`37`	`+ public function __construct(?SurrogateInterface $surrogate, FragmentRendererInterface $inlineStrategy, ?UriSigner $signer = null)`
`38`	`38`	`{`
`39`	`39`	`$this->surrogate = $surrogate;`
`40`	`40`	`$this->inlineStrategy = $inlineStrategy;`
Original file line number	Diff line number	Diff line change
`@@ -512,7 +512,7 @@ public function fooAction(?NonExistentClass $nonExistent = null)`
`512`	`512`	`{`
`513`	`513`	`}`
`514`	`514`
`515`		`- public function barAction(?NonExistentClass $nonExistent = null, $bar)`
	`515`	`+ public function barAction(?NonExistentClass $nonExistent, $bar)`
`516`	`516`	`{`
`517`	`517`	`}`
`518`	`518`	`}`
Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ public static function typesProvider()`
`157`	`157`	`/**`
`158`	`158`	`* @dataProvider provideCollectionTypes`
`159`	`159`	`*/`
`160`		`- public function testExtractCollection($property, ?array $type = null, $shortDescription, $longDescription)`
	`160`	`+ public function testExtractCollection($property, ?array $type, $shortDescription, $longDescription)`
`161`	`161`	`{`
`162`	`162`	`if (!class_exists(Collection::class)) {`
`163`	`163`	`$this->markTestSkipped('Collections are not implemented in current phpdocumentor/type-resolver version');`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ public function __construct(ValidatorInterface $validator, $root, TranslatorInte`
`152`	`152`	`/**`
`153`	`153`	`* {@inheritdoc}`
`154`	`154`	`*/`
`155`		`- public function setNode($value, ?object $object, ?MetadataInterface $metadata = null, string $propertyPath)`
	`155`	`+ public function setNode($value, ?object $object, ?MetadataInterface $metadata, string $propertyPath)`
`156`	`156`	`{`
`157`	`157`	`$this->value = $value;`
`158`	`158`	`$this->object = $object;`
Original file line number	Diff line number	Diff line change
`@@ -727,6 +727,6 @@ public static function stub(): void`
`727`	`727`	`}`
`728`	`728`	`}`
`729`	`729`
`730`		`-function reflectionParameterFixture(?NotLoadableClass $arg1 = null, $arg2)`
	`730`	`+function reflectionParameterFixture(?NotLoadableClass $arg1, $arg2)`
`731`	`731`	`{`
`732`	`732`	`}`