chore: improve expect.set_options timeout reset handling (microsoft#1981)

mxschmitt · web-flow · commit f8c4548e737a · 2023-06-16T21:46:48.000+02:00
diff --git a/playwright/async_api/__init__.py b/playwright/async_api/__init__.py
@@ -18,7 +18,7 @@
 web automation that is ever-green, capable, reliable and fast.
 """
 
-from typing import Optional, Union, overload
+from typing import Any, Optional, Union, overload
 
 import playwright._impl._api_structures
 import playwright._impl._api_types
@@ -88,10 +88,12 @@ def async_playwright() -> PlaywrightContextManager:
 
 
 class Expect:
+    _unset: Any = object()
+
     def __init__(self) -> None:
         self._timeout: Optional[float] = None
 
-    def set_options(self, timeout: float = None) -> None:
+    def set_options(self, timeout: Optional[float] = _unset) -> None:
         """
         This method sets global `expect()` options.
 
@@ -101,7 +103,7 @@ def set_options(self, timeout: float = None) -> None:
         Returns:
             None
         """
-        if timeout is not None:
+        if timeout is not self._unset:
             self._timeout = timeout
 
     @overload
diff --git a/playwright/sync_api/__init__.py b/playwright/sync_api/__init__.py
@@ -18,7 +18,7 @@
 web automation that is ever-green, capable, reliable and fast.
 """
 
-from typing import Optional, Union, overload
+from typing import Any, Optional, Union, overload
 
 import playwright._impl._api_structures
 import playwright._impl._api_types
@@ -88,10 +88,12 @@ def sync_playwright() -> PlaywrightContextManager:
 
 
 class Expect:
+    _unset: Any = object()
+
     def __init__(self) -> None:
         self._timeout: Optional[float] = None
 
-    def set_options(self, timeout: float = None) -> None:
+    def set_options(self, timeout: Optional[float] = _unset) -> None:
         """
         This method sets global `expect()` options.
 
@@ -101,7 +103,7 @@ def set_options(self, timeout: float = None) -> None:
         Returns:
             None
         """
-        if timeout is not None:
+        if timeout is not self._unset:
             self._timeout = timeout
 
     @overload
