Test out Service::disarm for all tower services #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
reviewed
Apr 3, 2020
LucioFranco
reviewed
Apr 3, 2020
|
|
||
| // Take self.ready so we can call &mut self methods below | ||
| let mut ready = std::mem::take(&mut self.ready); | ||
| for (key, (mut svc, cancel)) in ready.drain(..) { |
There was a problem hiding this comment.
Yeah... It's not expensive (like, it won't allocate for example), but it does mean that you might un-ready a bunch of services.
LucioFranco
reviewed
Apr 3, 2020
LucioFranco
reviewed
Apr 3, 2020
LucioFranco
reviewed
Apr 3, 2020
There was a problem hiding this comment.
Looks fine overall, I am just cautious about the panic for calling disarm wrong over just making it best effort?
I'd like @seanmonstar, @hawkw and @carllerche to take a look here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #408 and rust-lang/futures-rs#2109.