From aa4d7e5d0ee15253f20465b88dad19536c5952eb Mon Sep 17 00:00:00 2001
From: Vinccool96 <vinccool96@gmail.com>
Date: Fri, 20 Jun 2025 09:32:39 -0400
Subject: [PATCH] Switch to handwritten test cases

---
 .../tests/rules/no-unsafe-assignment.test.ts  | 406 +++++++++++++++---
 1 file changed, 335 insertions(+), 71 deletions(-)

diff --git a/packages/eslint-plugin/tests/rules/no-unsafe-assignment.test.ts b/packages/eslint-plugin/tests/rules/no-unsafe-assignment.test.ts
index 0f2654f22279..c72b71e70b49 100644
--- a/packages/eslint-plugin/tests/rules/no-unsafe-assignment.test.ts
+++ b/packages/eslint-plugin/tests/rules/no-unsafe-assignment.test.ts
@@ -1,65 +1,8 @@
-import type { InvalidTestCase } from '@typescript-eslint/rule-tester';
-
 import { noFormat, RuleTester } from '@typescript-eslint/rule-tester';
 
-import type {
-  InferMessageIdsTypeFromRule,
-  InferOptionsTypeFromRule,
-} from '../../src/util';
-
 import rule from '../../src/rules/no-unsafe-assignment';
 import { getFixturesRootDir } from '../RuleTester';
 
-type Options = InferOptionsTypeFromRule<typeof rule>;
-type MessageIds = InferMessageIdsTypeFromRule<typeof rule>;
-type InvalidTest = InvalidTestCase<MessageIds, Options>;
-
-const assignmentTest = (
-  tests: [string, number, number, boolean?][],
-): InvalidTest[] =>
-  tests.flatMap(([assignment, column, endColumn, skipAssignmentExpression]) => [
-    // VariableDeclaration
-    {
-      code: `const ${assignment}`,
-      errors: [
-        {
-          column: column + 6,
-          endColumn: endColumn + 6,
-          line: 1,
-          messageId: 'unsafeArrayPatternFromTuple',
-        },
-      ],
-    },
-    // AssignmentPattern
-    {
-      code: `function foo(${assignment}) {}`,
-      errors: [
-        {
-          column: column + 13,
-          endColumn: endColumn + 13,
-          line: 1,
-          messageId: 'unsafeArrayPatternFromTuple',
-        },
-      ],
-    },
-    // AssignmentExpression
-    ...(skipAssignmentExpression
-      ? []
-      : [
-          {
-            code: `(${assignment})`,
-            errors: [
-              {
-                column: column + 1,
-                endColumn: endColumn + 1,
-                line: 1,
-                messageId: 'unsafeArrayPatternFromTuple' as const,
-              },
-            ],
-          },
-        ]),
-  ]);
-
 const ruleTester = new RuleTester({
   languageOptions: {
     parserOptions: {
@@ -330,14 +273,193 @@ const [x] = [] as any[];
       ],
     },
 
-    ...assignmentTest([
-      ['[x] = [1] as [any]', 2, 3],
-      ['[[[[x]]]] = [[[[1 as any]]]]', 5, 6],
-      ['[[[[x]]]] = [1 as any]', 2, 9, true],
-      ['[{x}] = [{x: 1}] as [{x: any}]', 3, 4],
-      ['[{["x"]: x}] = [{["x"]: 1}] as [{["x"]: any}]', 10, 11],
-      ['[{[`x`]: x}] = [{[`x`]: 1}] as [{[`x`]: any}]', 10, 11],
-    ]),
+    {
+      code: 'const [x] = [1] as [any];',
+      errors: [
+        {
+          column: 8,
+          endColumn: 9,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: 'function foo([x] = [1] as [any]) {}',
+      errors: [
+        {
+          column: 15,
+          endColumn: 16,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: '[x] = [1] as [any];',
+      errors: [
+        {
+          column: 2,
+          endColumn: 3,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: 'const [[[[x]]]] = [[[[1 as any]]]];',
+      errors: [
+        {
+          column: 11,
+          endColumn: 12,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: 'function foo([[[[x]]]] = [[[[1 as any]]]]) {}',
+      errors: [
+        {
+          column: 18,
+          endColumn: 19,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: '[[[[x]]]] = [[[[1 as any]]]];',
+      errors: [
+        {
+          column: 5,
+          endColumn: 6,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: 'const [[[[x]]]] = [1 as any];',
+      errors: [
+        {
+          column: 8,
+          endColumn: 15,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: 'function foo([[[[x]]]] = [1 as any]) {}',
+      errors: [
+        {
+          column: 15,
+          endColumn: 22,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: 'const [{ x }] = [{ x: 1 }] as [{ x: any }];',
+      errors: [
+        {
+          column: 10,
+          endColumn: 11,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: 'function foo([{ x }] = [{ x: 1 }] as [{ x: any }]) {}',
+      errors: [
+        {
+          column: 17,
+          endColumn: 18,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: '[{ x }] = [{ x: 1 }] as [{ x: any }];',
+      errors: [
+        {
+          column: 4,
+          endColumn: 5,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: "const [{ ['x']: x }] = [{ ['x']: 1 }] as [{ ['x']: any }];",
+      errors: [
+        {
+          column: 17,
+          endColumn: 18,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: "function foo([{ ['x']: x }] = [{ ['x']: 1 }] as [{ ['x']: any }]) {}",
+      errors: [
+        {
+          column: 24,
+          endColumn: 25,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: "[{ ['x']: x }] = [{ ['x']: 1 }] as [{ ['x']: any }];",
+      errors: [
+        {
+          column: 11,
+          endColumn: 12,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: 'const [{ [`x`]: x }] = [{ [`x`]: 1 }] as [{ [`x`]: any }];',
+      errors: [
+        {
+          column: 17,
+          endColumn: 18,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: 'function foo([{ [`x`]: x }] = [{ [`x`]: 1 }] as [{ [`x`]: any }]) {}',
+      errors: [
+        {
+          column: 24,
+          endColumn: 25,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: '[{ [`x`]: x }] = [{ [`x`]: 1 }] as [{ [`x`]: any }];',
+      errors: [
+        {
+          column: 11,
+          endColumn: 12,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
     {
       // TS treats the assignment pattern weirdly in this case
       code: '[[[[x]]]] = [1 as any];',
@@ -364,12 +486,154 @@ const x = [...([] as any[])];
       errors: [{ messageId: 'unsafeArraySpread' }],
     },
 
-    ...assignmentTest([
-      ['{x} = {x: 1} as {x: any}', 2, 3],
-      ['{x: y} = {x: 1} as {x: any}', 5, 6],
-      ['{x: {y}} = {x: {y: 1}} as {x: {y: any}}', 6, 7],
-      ['{x: [y]} = {x: {y: 1}} as {x: [any]}', 6, 7],
-    ]),
+    {
+      code: 'const { x } = { x: 1 } as { x: any };',
+      errors: [
+        {
+          column: 9,
+          endColumn: 10,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: 'function foo({ x } = { x: 1 } as { x: any }) {}',
+      errors: [
+        {
+          column: 16,
+          endColumn: 17,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: '({ x } = { x: 1 } as { x: any });',
+      errors: [
+        {
+          column: 4,
+          endColumn: 5,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: 'const { x: y } = { x: 1 } as { x: any };',
+      errors: [
+        {
+          column: 12,
+          endColumn: 13,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: 'function foo({ x: y } = { x: 1 } as { x: any }) {}',
+      errors: [
+        {
+          column: 19,
+          endColumn: 20,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: '({ x: y } = { x: 1 } as { x: any });',
+      errors: [
+        {
+          column: 7,
+          endColumn: 8,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: `
+const {
+  x: { y },
+} = { x: { y: 1 } } as { x: { y: any } };
+      `,
+      errors: [
+        {
+          column: 8,
+          endColumn: 9,
+          line: 3,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: 'function foo({ x: { y } } = { x: { y: 1 } } as { x: { y: any } }) {}',
+      errors: [
+        {
+          column: 21,
+          endColumn: 22,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: `
+({
+  x: { y },
+} = { x: { y: 1 } } as { x: { y: any } });
+      `,
+      errors: [
+        {
+          column: 8,
+          endColumn: 9,
+          line: 3,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: `
+const {
+  x: [y],
+} = { x: { y: 1 } } as { x: [any] };
+      `,
+      errors: [
+        {
+          column: 7,
+          endColumn: 8,
+          line: 3,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: 'function foo({ x: [y] } = { x: { y: 1 } } as { x: [any] }) {}',
+      errors: [
+        {
+          column: 20,
+          endColumn: 21,
+          line: 1,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
+    {
+      code: `
+({
+  x: [y],
+} = { x: { y: 1 } } as { x: [any] });
+      `,
+      errors: [
+        {
+          column: 7,
+          endColumn: 8,
+          line: 3,
+          messageId: 'unsafeArrayPatternFromTuple',
+        },
+      ],
+    },
 
     {
       code: 'const x = { y: 1 as any };',

<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>
<html xmlns='http://www.w3.org/1999/xhtml'>
<head>
<title>pFad - Phonifier reborn</title>
<meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
</head>
<body>
<h1>Pfad - The Proxy pFad of &#169; 2024 Garber Painting. All rights reserved.</h1>


<!-- Disclaimer -->
<p>Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.</p>
<br>
<p>Alternative Proxies:</p><p><a href="http://clevelandohioweatherforecast.com/php-proxy/index.php?q=https://patch-diff.githubusercontent.com/raw/typescript-eslint/typescript-eslint/pull/11324.patch" target="_blank">Alternative Proxy</a></p><p><a href="http://clevelandohioweatherforecast.com/pFad/index.php?u=https://patch-diff.githubusercontent.com/raw/typescript-eslint/typescript-eslint/pull/11324.patch" target="_blank">pFad Proxy</a></p><p><a href="http://clevelandohioweatherforecast.com/pFad/v3index.php?u=https://patch-diff.githubusercontent.com/raw/typescript-eslint/typescript-eslint/pull/11324.patch" target="_blank">pFad v3 Proxy</a></p><p><a href="http://clevelandohioweatherforecast.com/pFad/v4index.php?u=https://patch-diff.githubusercontent.com/raw/typescript-eslint/typescript-eslint/pull/11324.patch" target="_blank">pFad v4 Proxy</a></p></body>
</html>