Skip to content

Specific redirect filter can't override generic redirection on 1.31.0 #1388

@Yuki2718

Description

@Yuki2718

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

In older versions, you could override where to redirect by creating a specific filter vs. generic redirect filter. E.g. uBlock Privacy has a generic redirect filter ||googletagmanager.com/gtm.js$script,redirect=googletagmanager.com/gtm.js but you could override it by e.g. ||googletagmanager.com/gtm.js$important,script,redirect=noopjs,domain=tv-asahi.co.jp (taken from the same list) and IIRC $important was not mandatory. However on 1.31.0 it doesn't work any more.

A specific URL where the issue occurs

https://rocketnews24.com/

Steps to Reproduce

  1. Visit the site with default setup (JP filter is not needed)
  2. Scroll down and see some images were not loaded at first visit
  3. Add @@||googletagmanager.com/gtm.js$script,domain=rocketnews24.com, clear cache & cookie, reload the page and see they're now loaded - but actually exception is not needed, redirecting to noop.js works.
  4. Add ||googletagmanager.com/gtm.js$important,script,redirect=noop.js,domain=rocketnews24.com or ||googletagmanager.com/gtm.js$important,script,redirect=none,domain=rocketnews24.com and see the request still redirects to googletagmanager.com/gtm.js. Relaunch browser or whatsoever doesn't help, only way to make it work seems to be badfilter.

Expected behavior:

The specific redirect rule should override generic one.

Actual behavior:

Generic filter wins.

Your environment

  • uBlock Origin version: 1.31.0
  • Browser Name and version: Firefox 83.0
  • Operating System and version: Windows 10

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingfixedissue has been addressed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy