Skip to content

fix: add 1bps fee tier to tick_spacing and bitmap_spacing constants. #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

KeremP
Copy link
Contributor

@KeremP KeremP commented Oct 1, 2022

fixes #277

@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Base: 84.56% // Head: 84.17% // Decreases project coverage by -0.38% ⚠️

Coverage data is based on head (78c3536) compared to base (ff26afb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
- Coverage   84.56%   84.17%   -0.39%     
==========================================
  Files          10       10              
  Lines        1030     1030              
==========================================
- Hits          871      867       -4     
- Misses        159      163       +4     
Impacted Files Coverage Δ
uniswap/constants.py 100.00% <100.00%> (ø)
uniswap/tokens.py 64.28% <0.00%> (-21.43%) ⬇️
uniswap/uniswap.py 82.46% <0.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@TheBlueMastiff TheBlueMastiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ErikBjare ErikBjare merged commit dc053cd into uniswap-python:master Oct 2, 2022
@ErikBjare
Copy link
Member

Thanks @KeremP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 100 when trying to get bitmap spacing for 0.01% pool
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy