add more strict CXX options

tulequ · tulequ · commit b58c93e89053 · 2018-07-01T18:31:46.000+07:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,7 +1,7 @@
 cmake_minimum_required (VERSION 3.0)
 project (libunikey)
 
-add_compile_options(-std=c++11 -Werror)
+add_compile_options(-std=c++11 -Werror -Wall -pedantic)
 
 add_subdirectory(ukengine)
 add_subdirectory(src)
diff --git a/src/unikey.cpp b/src/unikey.cpp
@@ -100,8 +100,7 @@ void SimpleUnikey::process_backspace() {
 }
 
 void SimpleUnikey::process(std::string const& str) {
-  UkOutputType oType;
-  for (int i = 0; i < str.length(); i++) {
+  for (unsigned int i = 0; i < str.length(); i++) {
     process(str[i]);
   }
 }
diff --git a/src/unikey.h b/src/unikey.h
@@ -4,7 +4,7 @@
 #include <string>
 
 class UkEngine;
-class UkSharedMem;
+struct UkSharedMem;
 
 namespace unikey {
 
diff --git a/ukengine/byteio.cpp b/ukengine/byteio.cpp
@@ -155,7 +155,7 @@ int StringBIStream::gotoBookmark()
 int StringBIStream::close()
 {
 	return 1;
-};
+}
 
 //////////////////////////////////////////////////
 // Class StringBOStream

Original file line number	Diff line number	Diff line change
`@@ -100,8 +100,7 @@ void SimpleUnikey::process_backspace() {`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`void SimpleUnikey::process(std::string const& str) {`
`103`		`- UkOutputType oType;`
`104`		`- for (int i = 0; i < str.length(); i++) {`
	`103`	`+ for (unsigned int i = 0; i < str.length(); i++) {`
`105`	`104`	`process(str[i]);`
`106`	`105`	`}`
`107`	`106`	`}`
Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ int StringBIStream::gotoBookmark()`
`155`	`155`	`int StringBIStream::close()`
`156`	`156`	`{`
`157`	`157`	`return 1;`
`158`		`-};`
	`158`	`+}`
`159`	`159`
`160`	`160`	`//////////////////////////////////////////////////`
`161`	`161`	`// Class StringBOStream`