fix: put more error logs behind debug info setting

Akryum · Akryum · commit db49152ea59e · 2024-02-05T11:44:29.000+01:00
diff --git a/packages/app-backend-api/src/hooks.ts b/packages/app-backend-api/src/hooks.ts
@@ -1,4 +1,4 @@
-import { PluginPermission, hasPluginPermission } from '@vue-devtools/shared-utils'
+import { PluginPermission, SharedData, hasPluginPermission } from '@vue-devtools/shared-utils'
 import type { HookHandler, HookPayloads, Hookable } from '@vue/devtools-api'
 import { Hooks } from '@vue/devtools-api'
 import type { BackendContext } from './backend-context'
@@ -59,8 +59,10 @@ export class DevtoolsHookable implements Hookable<BackendContext> {
           await handler(payload, ctx)
         }
         catch (e) {
-          console.error(`An error occurred in hook '${eventType}'${plugin ? ` registered by plugin '${plugin.descriptor.id}'` : ''} with payload:`, payload)
-          console.error(e)
+          if (SharedData.debugInfo) {
+            console.error(`An error occurred in hook '${eventType}'${plugin ? ` registered by plugin '${plugin.descriptor.id}'` : ''} with payload:`, payload)
+            console.error(e)
+          }
         }
       }
     }
diff --git a/packages/app-backend-core/src/app.ts b/packages/app-backend-core/src/app.ts
@@ -272,8 +272,10 @@ export function _legacy_getAndRegisterApps(ctx: BackendContext, clear = false) {
       })
     }
     catch (e) {
-      console.error(`Error scanning for legacy apps:`)
-      console.error(e)
+      if (SharedData.debugInfo) {
+        console.error(`Error scanning for legacy apps:`)
+        console.error(e)
+      }
     }
   }, 0)
 }
diff --git a/packages/app-backend-core/src/index.ts b/packages/app-backend-core/src/index.ts
@@ -407,15 +407,19 @@ async function connect() {
     await addPreviouslyRegisteredPlugins(ctx)
   }
   catch (e) {
-    console.error(`Error adding previously registered plugins:`)
-    console.error(e)
+    if (SharedData.debugInfo) {
+      console.error(`Error adding previously registered plugins:`)
+      console.error(e)
+    }
   }
   try {
     await addQueuedPlugins(ctx)
   }
   catch (e) {
-    console.error(`Error adding queued plugins:`)
-    console.error(e)
+    if (SharedData.debugInfo) {
+      console.error(`Error adding queued plugins:`)
+      console.error(e)
+    }
   }
 
   hook.on(HookEvents.SETUP_DEVTOOLS_PLUGIN, async (pluginDescriptor: PluginDescriptor, setupFn: SetupFunction) => {
@@ -450,8 +454,10 @@ async function connect() {
     }, ctx)
   }
   catch (e) {
-    console.error(`Error while adding devtools connected timeline marker:`)
-    console.error(e)
+    if (SharedData.debugInfo) {
+      console.error(`Error while adding devtools connected timeline marker:`)
+      console.error(e)
+    }
   }
 }
 
@@ -589,10 +595,12 @@ function connectBridge() {
         await action()
       }
       catch (e) {
-        console.error(e)
+        if (SharedData.debugInfo) {
+          console.error(e)
+        }
       }
     }
-    else {
+    else if (SharedData.debugInfo) {
       console.warn(`Couldn't revive action ${actionIndex} from`, value)
     }
   })

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { PluginPermission, hasPluginPermission } from '@vue-devtools/shared-utils'`
	`1`	`+import { PluginPermission, SharedData, hasPluginPermission } from '@vue-devtools/shared-utils'`
`2`	`2`	`import type { HookHandler, HookPayloads, Hookable } from '@vue/devtools-api'`
`3`	`3`	`import { Hooks } from '@vue/devtools-api'`
`4`	`4`	`import type { BackendContext } from './backend-context'`
`@@ -59,8 +59,10 @@ export class DevtoolsHookable implements Hookable<BackendContext> {`
`59`	`59`	`await handler(payload, ctx)`
`60`	`60`	`}`
`61`	`61`	`catch (e) {`
`62`		- console.error(`An error occurred in hook '${eventType}'${plugin ? ` registered by plugin '${plugin.descriptor.id}'` : ''} with payload:`, payload)
`63`		`- console.error(e)`
	`62`	`+ if (SharedData.debugInfo) {`
	`63`	+ console.error(`An error occurred in hook '${eventType}'${plugin ? ` registered by plugin '${plugin.descriptor.id}'` : ''} with payload:`, payload)
	`64`	`+ console.error(e)`
	`65`	`+ }`
`64`	`66`	`}`
`65`	`67`	`}`
`66`	`68`	`}`
Original file line number	Diff line number	Diff line change
`@@ -272,8 +272,10 @@ export function _legacy_getAndRegisterApps(ctx: BackendContext, clear = false) {`
`272`	`272`	`})`
`273`	`273`	`}`
`274`	`274`	`catch (e) {`
`275`		- console.error(`Error scanning for legacy apps:`)
`276`		`- console.error(e)`
	`275`	`+ if (SharedData.debugInfo) {`
	`276`	+ console.error(`Error scanning for legacy apps:`)
	`277`	`+ console.error(e)`
	`278`	`+ }`
`277`	`279`	`}`
`278`	`280`	`}, 0)`
`279`	`281`	`}`
Original file line number	Diff line number	Diff line change
`@@ -407,15 +407,19 @@ async function connect() {`
`407`	`407`	`await addPreviouslyRegisteredPlugins(ctx)`
`408`	`408`	`}`
`409`	`409`	`catch (e) {`
`410`		- console.error(`Error adding previously registered plugins:`)
`411`		`- console.error(e)`
	`410`	`+ if (SharedData.debugInfo) {`
	`411`	+ console.error(`Error adding previously registered plugins:`)
	`412`	`+ console.error(e)`
	`413`	`+ }`
`412`	`414`	`}`
`413`	`415`	`try {`
`414`	`416`	`await addQueuedPlugins(ctx)`
`415`	`417`	`}`
`416`	`418`	`catch (e) {`
`417`		- console.error(`Error adding queued plugins:`)
`418`		`- console.error(e)`
	`419`	`+ if (SharedData.debugInfo) {`
	`420`	+ console.error(`Error adding queued plugins:`)
	`421`	`+ console.error(e)`
	`422`	`+ }`
`419`	`423`	`}`
`420`	`424`
`421`	`425`	`hook.on(HookEvents.SETUP_DEVTOOLS_PLUGIN, async (pluginDescriptor: PluginDescriptor, setupFn: SetupFunction) => {`
`@@ -450,8 +454,10 @@ async function connect() {`
`450`	`454`	`}, ctx)`
`451`	`455`	`}`
`452`	`456`	`catch (e) {`
`453`		- console.error(`Error while adding devtools connected timeline marker:`)
`454`		`- console.error(e)`
	`457`	`+ if (SharedData.debugInfo) {`
	`458`	+ console.error(`Error while adding devtools connected timeline marker:`)
	`459`	`+ console.error(e)`
	`460`	`+ }`
`455`	`461`	`}`
`456`	`462`	`}`
`457`	`463`
`@@ -589,10 +595,12 @@ function connectBridge() {`
`589`	`595`	`await action()`
`590`	`596`	`}`
`591`	`597`	`catch (e) {`
`592`		`- console.error(e)`
	`598`	`+ if (SharedData.debugInfo) {`
	`599`	`+ console.error(e)`
	`600`	`+ }`
`593`	`601`	`}`
`594`	`602`	`}`
`595`		`- else {`
	`603`	`+ else if (SharedData.debugInfo) {`
`596`	`604`	console.warn(`Couldn't revive action ${actionIndex} from`, value)
`597`	`605`	`}`
`598`	`606`	`})`