Skip to content

test(useVModels): add missing test coverage #4876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

test(useVModels): add missing test coverage #4876

merged 1 commit into from
Jul 14, 2025

Conversation

broBinChen
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

This PR adds comprehensive test coverage for the useVModels composable, which was previously missing test cases.

What this PR solves:

  • Addresses the lack of test coverage for useVModels hook
  • Ensures reliability and prevents potential regressions
  • Provides test examples for proper usage patterns
    
    All tests pass and provide complete coverage of the useVModels functionality without changing any existing behavior.

Additional context

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 14, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 14, 2025
@antfu antfu added this pull request to the merge queue Jul 14, 2025
Merged via the queue into vueuse:main with commit c28c06f Jul 14, 2025
8 checks passed
@broBinChen broBinChen deleted the test/add-useVModels-comprehensive-tests branch July 14, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrbisK OrbisK OrbisK approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@broBinChen @OrbisK @antfu
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy