Skip to content

test: add comprehensive tests for useStorageAsync #4877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

test: add comprehensive tests for useStorageAsync #4877

wants to merge 5 commits into from

Conversation

broBinChen
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

This PR adds comprehensive test coverage for the useStorageAsync composable, which was missing test cases.

What this PR solves:

  • Adds 28 test cases covering all functionality of useStorageAsync
  • Ensures proper testing of async storage operations
  • Improves code quality and maintainability through better test coverage

Test coverage includes:

  • Basic data types (string, number, boolean, null, undefined)
  • Complex data structures (objects, arrays, Map, Set, Date)
  • All configuration options (eventFilter, mergeDefaults, writeDefaults, shallow, flush)
  • Error handling scenarios (read errors, write errors, serialization errors)
  • Async operations and storage synchronization
  • Edge cases and storage events

Additional context

  • This PR only adds tests without modifying the existing useStorageAsync implementation
  • All tests are designed to work with the current async storage interface
  • The test file follows the project's testing conventions and uses the same testing utilities
  • No breaking changes or new dependencies are introduced

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 14, 2025
@broBinChen broBinChen closed this Jul 15, 2025
@broBinChen broBinChen reopened this Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@broBinChen
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy