Skip to content

Commit 518cab8

Browse files
committed
Revert "fix: Use urllib instead of curl (microsoft#302)"
urllib does not know which certificates and good and which are bad.
1 parent f11b984 commit 518cab8

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

build_package.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import stat
1919
import subprocess
2020
import sys
21-
import urllib.request
2221
import zipfile
2322

2423
from playwright.path_utils import get_file_dirname
@@ -36,7 +35,7 @@
3635
if not os.path.exists("driver/" + zip_file):
3736
url = "https://playwright.azureedge.net/builds/cli/next/" + zip_file
3837
print("Fetching ", url)
39-
urllib.request.urlretrieve(url, "driver/" + zip_file)
38+
subprocess.check_call(["curl", url, "-o", "driver/" + zip_file])
4039

4140
_dirname = get_file_dirname()
4241
_build_dir = _dirname / "build"

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy