Skip to content

Commit f123f8f

Browse files
mxschmittmxschmitt
authored
chore: bump linters (pre-commit) (microsoft#1624)
1 parent 9b2d682 commit f123f8f

22 files changed

+45
-41
lines changed

‎.pre-commit-config.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@ repos:
1515
- id: check-executables-have-shebangs
1616
- id: check-merge-conflict
1717
- repo: https://github.com/psf/black
18-
rev: 22.6.0
18+
rev: 22.10.0
1919
hooks:
2020
- id: black
2121
- repo: https://github.com/pre-commit/mirrors-mypy
22-
rev: v0.971
22+
rev: v0.982
2323
hooks:
2424
- id: mypy
25-
additional_dependencies: [types-pyOpenSSL==21.0.3]
25+
additional_dependencies: [types-pyOpenSSL==22.1.0.1]
2626
exclude: examples/
2727
- repo: https://github.com/pycqa/flake8
2828
rev: 5.0.4
@@ -40,4 +40,4 @@ repos:
4040
language: node
4141
pass_filenames: false
4242
types: [python]
43-
additional_dependencies: ["pyright@1.1.210"]
43+
additional_dependencies: ["pyright@1.1.278"]

‎playwright/_impl/__pyinstaller/hook-playwright.async_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
from PyInstaller.utils.hooks import collect_data_files
15+
from PyInstaller.utils.hooks import collect_data_files # type: ignore
1616

1717
datas = collect_data_files("playwright")

‎playwright/_impl/__pyinstaller/hook-playwright.sync_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
from PyInstaller.utils.hooks import collect_data_files
15+
from PyInstaller.utils.hooks import collect_data_files # type: ignore
1616

1717
datas = collect_data_files("playwright")

‎pyproject.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,3 +37,6 @@ pythonVersion = "3.7"
3737
reportMissingImports = false
3838
reportTypedDictNotRequiredAccess = false
3939
reportCallInDefaultInitializer = true
40+
reportOptionalSubscript = false
41+
reportUnboundVariable = false
42+
strictParameterNoneValue = false

‎tests/async/test_browsercontext.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ async def test_page_event_should_have_an_opener(context, server):
681681
page = await context.new_page()
682682
await page.goto(server.EMPTY_PAGE)
683683
async with context.expect_page() as page_info:
684-
await page.goto(server.PREFIX + "/popup/window-open.html"),
684+
await page.goto(server.PREFIX + "/popup/window-open.html")
685685
popup = await page_info.value
686686
assert popup.url == server.PREFIX + "/popup/popup.html"
687687
assert await popup.opener() == page

‎tests/async/test_console.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ async def test_console_should_trigger_correct_log(page, server):
111111
async def test_console_should_have_location_for_console_api_calls(page, server):
112112
await page.goto(server.EMPTY_PAGE)
113113
async with page.expect_console_message() as message_info:
114-
await page.goto(server.PREFIX + "/consolelog.html"),
114+
await page.goto(server.PREFIX + "/consolelog.html")
115115
message = await message_info.value
116116
assert message.text == "yellow"
117117
assert message.type == "log"

‎tests/async/test_device_descriptors.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@ async def test_should_work(playwright, launch_arguments) -> None:
2121

2222
assert device_descriptor["viewport"]["height"] > 700
2323
assert device_descriptor["viewport"]["height"] < 800
24-
inner_height = await page.evaluate("window.innerHeight")
25-
inner_height > 700
26-
inner_height < 800
24+
inner_height = await page.evaluate("window.screen.availHeight")
25+
assert inner_height > 700
26+
assert inner_height < 800
2727

2828
assert device_descriptor["viewport"]["width"] > 400
2929
assert device_descriptor["viewport"]["width"] < 500
30-
inner_width = await page.evaluate("window.innerWidth")
31-
inner_width > 400
32-
inner_width < 500
30+
inner_width = await page.evaluate("window.screen.availWidth")
31+
assert inner_width > 400
32+
assert inner_width < 500
3333

3434
assert device_descriptor["has_touch"]
3535
assert device_descriptor["is_mobile"]

‎tests/async/test_geolocation.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,9 @@ async def test_watch_position_should_be_notified(page, server, context):
112112
await context.set_geolocation({"latitude": 40, "longitude": 50})
113113

114114
all_messages = "|".join(messages)
115-
"latitude=0 lng=10" in all_messages
116-
"latitude=20 lng=30" in all_messages
117-
"latitude=40 lng=50" in all_messages
115+
assert "lat=0 lng=10" in all_messages
116+
assert "lat=20 lng=30" in all_messages
117+
assert "lat=40 lng=50" in all_messages
118118

119119

120120
async def test_should_use_context_options_for_popup(page, context, server):

‎tests/async/test_interception.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ async def test_page_route_should_work_when_POST_is_redirected_with_302(page, ser
103103
"""
104104
)
105105
async with page.expect_navigation():
106-
await page.eval_on_selector("form", "form => form.submit()"),
106+
await page.eval_on_selector("form", "form => form.submit()")
107107

108108

109109
# @see https://github.com/GoogleChrome/puppeteer/issues/3973

‎tests/async/test_locators.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ async def test_locators_should_upload_a_file(page: Page, server: Server):
327327
async def test_locators_should_press(page: Page):
328328
await page.set_content("<input type='text' />")
329329
await page.locator("input").press("h")
330-
await page.eval_on_selector("input", "input => input.value") == "h"
330+
assert await page.eval_on_selector("input", "input => input.value") == "h"
331331

332332

333333
async def test_locators_should_scroll_into_view(page: Page, server: Server):
@@ -363,7 +363,7 @@ async def test_locators_should_select_textarea(
363363
async def test_locators_should_type(page: Page):
364364
await page.set_content("<input type='text' />")
365365
await page.locator("input").type("hello")
366-
await page.eval_on_selector("input", "input => input.value") == "hello"
366+
assert await page.eval_on_selector("input", "input => input.value") == "hello"
367367

368368

369369
async def test_locators_should_screenshot(

‎tests/async/test_navigation.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ async def test_wait_for_nav_should_work_with_clicking_on_anchor_links(page, serv
464464
await page.goto(server.EMPTY_PAGE)
465465
await page.set_content('<a href="#foobar">foobar</a>')
466466
async with page.expect_navigation() as response_info:
467-
await page.click("a"),
467+
await page.click("a")
468468
response = await response_info.value
469469
assert response is None
470470
assert page.url == server.EMPTY_PAGE + "#foobar"
@@ -477,7 +477,7 @@ async def test_wait_for_nav_should_work_with_clicking_on_links_which_do_not_comm
477477
await page.set_content(f"<a href='{https_server.EMPTY_PAGE}'>foobar</a>")
478478
with pytest.raises(Error) as exc_info:
479479
async with page.expect_navigation():
480-
await page.click("a"),
480+
await page.click("a")
481481
expect_ssl_error(exc_info.value.message, browser_name)
482482

483483

@@ -492,7 +492,7 @@ async def test_wait_for_nav_should_work_with_history_push_state(page, server):
492492
"""
493493
)
494494
async with page.expect_navigation() as response_info:
495-
await page.click("a"),
495+
await page.click("a")
496496
response = await response_info.value
497497
assert response is None
498498
assert page.url == server.PREFIX + "/wow.html"
@@ -509,7 +509,7 @@ async def test_wait_for_nav_should_work_with_history_replace_state(page, server)
509509
"""
510510
)
511511
async with page.expect_navigation() as response_info:
512-
await page.click("a"),
512+
await page.click("a")
513513
response = await response_info.value
514514
assert response is None
515515
assert page.url == server.PREFIX + "/replaced.html"
@@ -531,12 +531,12 @@ async def test_wait_for_nav_should_work_with_dom_history_back_forward(page, serv
531531
)
532532
assert page.url == server.PREFIX + "/second.html"
533533
async with page.expect_navigation() as back_response_info:
534-
await page.click("a#back"),
534+
await page.click("a#back")
535535
back_response = await back_response_info.value
536536
assert back_response is None
537537
assert page.url == server.PREFIX + "/first.html"
538538
async with page.expect_navigation() as forward_response_info:
539-
await page.click("a#forward"),
539+
await page.click("a#forward")
540540
forward_response = await forward_response_info.value
541541
assert forward_response is None
542542
assert page.url == server.PREFIX + "/second.html"

‎tests/async/test_page.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,15 +174,15 @@ async def test_async_stacks_should_work(page, server):
174174

175175
async def test_opener_should_provide_access_to_the_opener_page(page):
176176
async with page.expect_popup() as popup_info:
177-
await page.evaluate("window.open('about:blank')"),
177+
await page.evaluate("window.open('about:blank')")
178178
popup = await popup_info.value
179179
opener = await popup.opener()
180180
assert opener == page
181181

182182

183183
async def test_opener_should_return_null_if_parent_page_has_been_closed(page):
184184
async with page.expect_popup() as popup_info:
185-
await page.evaluate("window.open('about:blank')"),
185+
await page.evaluate("window.open('about:blank')")
186186
popup = await popup_info.value
187187
await page.close()
188188
opener = await popup.opener()

‎tests/async/test_popup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ async def handle_request(route: Route) -> None:
5454

5555
await context.route("**/empty.html", handle_request)
5656
async with context.expect_page():
57-
await page.click("a"),
57+
await page.click("a")
5858
assert intercepted == [True]
5959

6060

‎tests/async/test_wait_for_url.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,11 @@ async def test_wait_for_url_should_work_with_dom_history_back_forward(
102102

103103
assert page.url == server.PREFIX + "/second.html"
104104

105-
await page.click("a#back"),
105+
await page.click("a#back")
106106
await page.wait_for_url("**/first.html")
107107
assert page.url == server.PREFIX + "/first.html"
108108

109-
await page.click("a#forward"),
109+
await page.click("a#forward")
110110
await page.wait_for_url("**/second.html")
111111
assert page.url == server.PREFIX + "/second.html"
112112

‎tests/async/test_worker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ async def test_workers_should_clear_upon_cross_process_navigation(server, page):
139139

140140
async def test_workers_should_report_network_activity(page, server):
141141
async with page.expect_worker() as worker_info:
142-
await page.goto(server.PREFIX + "/worker/worker.html"),
142+
await page.goto(server.PREFIX + "/worker/worker.html")
143143
worker = await worker_info.value
144144
url = server.PREFIX + "/one-style.css"
145145
async with page.expect_request(url) as request_info, page.expect_response(

‎tests/sync/test_browsercontext_request_fallback.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ def test_should_amend_post_data(
290290
context.route("**/*", lambda route: route.fallback(post_data="doggo"))
291291

292292
with server.expect_request("/sleep.zzz") as server_request_info:
293-
page.evaluate("() => fetch('/sleep.zzz', { method: 'POST', body: 'birdy' })"),
293+
page.evaluate("() => fetch('/sleep.zzz', { method: 'POST', body: 'birdy' })")
294294
server_request = server_request_info.value
295295
assert post_data == ["doggo"]
296296
assert server_request.post_body == b"doggo"

‎tests/sync/test_console.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def test_console_should_work(page: Page, browser_name: str) -> None:
2424
messages: List[ConsoleMessage] = []
2525
page.once("console", lambda m: messages.append(m))
2626
with page.expect_console_message():
27-
page.evaluate('() => console.log("hello", 5, {foo: "bar"})'),
27+
page.evaluate('() => console.log("hello", 5, {foo: "bar"})')
2828
assert len(messages) == 1
2929
message = messages[0]
3030
if browser_name != "firefox":
@@ -108,7 +108,7 @@ def test_console_should_not_fail_for_window_object(
108108
def test_console_should_trigger_correct_Log(page: Page, server: Server) -> None:
109109
page.goto("about:blank")
110110
with page.expect_console_message() as message:
111-
page.evaluate("url => fetch(url).catch(e => {})", server.EMPTY_PAGE),
111+
page.evaluate("url => fetch(url).catch(e => {})", server.EMPTY_PAGE)
112112
assert "Access-Control-Allow-Origin" in message.value.text
113113
assert message.value.type == "error"
114114

‎tests/sync/test_fetch_global.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def test_should_propagate_extra_http_headers_with_redirects(
7979
with server.expect_request("/a/redirect1") as server_req1:
8080
with server.expect_request("/b/c/redirect2") as server_req2:
8181
with server.expect_request("/simple.json") as server_req3:
82-
request.get(f"{server.PREFIX}/a/redirect1"),
82+
request.get(f"{server.PREFIX}/a/redirect1")
8383
assert server_req1.value.getHeader("my-secret") == "Value"
8484
assert server_req2.value.getHeader("my-secret") == "Value"
8585
assert server_req3.value.getHeader("my-secret") == "Value"
@@ -142,7 +142,7 @@ def test_should_use_playwright_as_a_user_agent(
142142
) -> None:
143143
request = playwright.request.new_context()
144144
with server.expect_request("/empty.html") as server_req:
145-
request.get(server.EMPTY_PAGE),
145+
request.get(server.EMPTY_PAGE)
146146
assert str(server_req.value.getHeader("User-Agent")).startswith("Playwright/")
147147
request.dispose()
148148

‎tests/sync/test_locators.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ def test_locators_should_upload_a_file(page: Page, server: Server) -> None:
320320
def test_locators_should_press(page: Page) -> None:
321321
page.set_content("<input type='text' />")
322322
page.locator("input").press("h")
323-
page.eval_on_selector("input", "input => input.value") == "h"
323+
assert page.eval_on_selector("input", "input => input.value") == "h"
324324

325325

326326
def test_locators_should_scroll_into_view(page: Page, server: Server) -> None:
@@ -356,7 +356,7 @@ def test_locators_should_select_textarea(
356356
def test_locators_should_type(page: Page) -> None:
357357
page.set_content("<input type='text' />")
358358
page.locator("input").type("hello")
359-
page.eval_on_selector("input", "input => input.value") == "hello"
359+
assert page.eval_on_selector("input", "input => input.value") == "hello"
360360

361361

362362
def test_locators_should_screenshot(

‎tests/sync/test_page_request_fallback.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ def test_should_amend_post_data(page: Page, server: Server) -> None:
270270
page.route("**/*", lambda route: route.fallback(post_data="doggo"))
271271

272272
with server.expect_request("/sleep.zzz") as server_request_info:
273-
page.evaluate("() => fetch('/sleep.zzz', { method: 'POST', body: 'birdy' })"),
273+
page.evaluate("() => fetch('/sleep.zzz', { method: 'POST', body: 'birdy' })")
274274
server_request = server_request_info.value
275275
assert post_data == ["doggo"]
276276
assert server_request.post_body == b"doggo"

‎tests/sync/test_sync.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ def test_sync_network_events(page: Page, server: Server) -> None:
190190
def test_console_should_work(page: Page, browser_name: str) -> None:
191191
messages = []
192192
page.once("console", lambda m: messages.append(m))
193-
page.evaluate('() => console.log("hello", 5, {foo: "bar"})'),
193+
page.evaluate('() => console.log("hello", 5, {foo: "bar"})')
194194
assert len(messages) == 1
195195
message = messages[0]
196196
if browser_name != "firefox":

‎tests/sync/test_video.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ def test_should_error_if_page_not_closed_before_save_as(
105105
video = page.video
106106
assert video
107107
video.save_as(out_path)
108+
assert video
108109
assert "Page is not yet closed. Close the page prior to calling save_as" in str(err)
109110
assert not os.path.exists(out_path)
110111
page.context.close()

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy