This repository was archived by the owner on Jan 8, 2020. It is now read-only.
[mail] Fix set UTF-8 values to headers. Fix #7501 #7506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new Exception\InvalidArgumentException('Email must be a valid email address'); | ||
| } | ||
|
|
||
| if (preg_match("/[\r|\n]/", $email)) { |
There was a problem hiding this comment.
You can remove the | character as this is a character class.
| $this->setEncoding('ASCII'); | ||
| } else { | ||
| $this->setEncoding('UTF-8'); | ||
| } |
There was a problem hiding this comment.
Let's make this a ternary:
$this->encoding = Mime::isPrintable($this->fieldValue) ? 'ASCII' : 'UTF-8';| $this->setEncoding('ASCII'); | ||
| } else { | ||
| $this->setEncoding('UTF-8'); | ||
| } |
There was a problem hiding this comment.
Same comment as above; make this a ternary.
weierophinney
added a commit
that referenced
this pull request
May 8, 2015
[mail] Fix set UTF-8 values to headers. Fix #7501
weierophinney
added a commit
that referenced
this pull request
May 8, 2015
[mail] Fix set UTF-8 values to headers. Fix #7501
weierophinney
added a commit
that referenced
this pull request
May 8, 2015
This was referenced May 8, 2015
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
…x/mail-utf8 [mail] Fix set UTF-8 values to headers. Fix zendframework/zendframework#7501
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
…x/mail-utf8 [mail] Fix set UTF-8 values to headers. Fix zendframework/zendframework#7501
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.