Skip to content

Remove samples/common #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Pyrolistical opened this issue May 22, 2024 · 0 comments
Open

Remove samples/common #604

Pyrolistical opened this issue May 22, 2024 · 0 comments

Comments

@Pyrolistical
Copy link
Contributor

Pyrolistical commented May 22, 2024 •
edited
Loading

Blocks #597

d3d12 samples that depend on samples/common were created before zgui/zmath and can be refactored:
#559 (comment)

samples/common holds the csGenerateMipmaps in common.hsl, which belongs in zd3d12 alongside zd3d12.MipmapGenerator.

FrameStats should be moved to zd3d12.GraphicsContext to reach parity with zgpu.GraphicsContext

The following depend on samples/common:

  1. samples\audio_experiments
  2. samples\audio_playback_test
  3. samples\bindless
  4. samples\directml_convolution_test
  5. samples\mesh_shader_test
  6. samples\rasterization
  7. samples\simple_raytracer
  8. samples\textured_quad
  9. samples\triangle
  10. samples\vector_graphics_test
  11. samples\simple_openvr (common.hlsl only)
@hazeycode hazeycode added this to the 0.7.0 milestone Jun 15, 2024
@hazeycode hazeycode removed this from the 0.7.0 milestone Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pyrolistical @hazeycode
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy