Page MenuHomePhabricator
Create Task
Maniphest T316936

Language names in wbqc-violation-message-label-lacking aren't translated to the language of the user interface
Closed, ResolvedPublicBUG REPORT
Actions

Description

The constraint message that is displayed when a required language couldn't be found in the labels of an entity has languages names written in the same language that is required instead of in the language of the user interface. When this is a language I don't understand I'm unable to know which language is the one missing. I can't fix the problem without understanding the language, but it would be nice knowing at least which one the missing language is.

Example:

image.png (198×571 px, 20 KB)

https://www.wikidata.org/wiki/Q100257812#P4529

What happens?:
Language names in wbqc-violation-message-label-lacking message are displayed written in that language.

What should have happened instead?:
Language names of the message should be displayed written in the language of the user interface.

Details

SubjectRepoBranchLines +/-
Use ViolationMessageRendererFactory in SpecialConstraintReportmediawiki/extensions/WikibaseQualityConstraintsmaster+11 -15
Format language constraint parameters in user languagemediawiki/extensions/WikibaseQualityConstraintsmaster+14 -5
Move ViolationMessageRendererFactory to service containermediawiki/extensions/WikibaseQualityConstraintsmaster+27 -41
Move MessageLocalizer in ViolationMessageRendererFactorymediawiki/extensions/WikibaseQualityConstraintsmaster+17 -16
Add strict types to ViolationMessageRenderermediawiki/extensions/WikibaseQualityConstraintsmaster+21 -27
Inject LanguageNameUtils into ViolationMessageRenderer(Factory)mediawiki/extensions/WikibaseQualityConstraintsmaster+53 -40
Simplify MultilingualTextViolationMessageRenderermediawiki/extensions/WikibaseQualityConstraintsmaster+5 -30
Customize query in gerrit

Event Timeline

Agabi10 created this task.Sep 2 2022, 1:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2022, 1:40 PM
Maintenance_bot added a project: Wikidata.Sep 2 2022, 1:45 PM
Lucas_Werkmeister_WMDE subscribed.Sep 5 2022, 1:34 PM

Should be relatively easy to change – pass the user language from ViolationMessageRendererFactory::getViolationMessageRenderer() into ViolationMessageRenderer, then adjust ViolationMessageRenderer::renderLanguage() to pass the user language code into Language::fetchLanguageName(). Violation messages are rendered per request – the cache contains the unrendered, serialized message – so there should be no issues about wrong language names being shown to other users due to bad caching.

It would be nice, but not required, to also refactor the code at this time, to inject a LanguageNameUtils service instance into ViolationMessageRenderer and its factory, instead of using the deprecated Language::fetchLanguageName() method.

This could potentially be a good first task, but needs a product decision first IMHO, on whether we want to make this change or not.

Lydia_Pintscher subscribed.Sep 9 2022, 4:04 PM

Do you have an example where this is happening so I can have a closer look?

Agabi10 added a comment.Sep 9 2022, 5:26 PM
In T316936#8225124, @Lydia_Pintscher wrote:

Do you have an example where this is happening so I can have a closer look?

Here is an example: https://www.wikidata.org/wiki/Q100257812#P4529

Lydia_Pintscher added a comment.Sep 10 2022, 10:17 AM

Thank you! That makes sense. And I'd agree that changing it to show the language in the interface language makes sense.

Lydia_Pintscher added a project: good first task.Sep 10 2022, 10:18 AM
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher added a project: Wikidata Dev Team.Dec 2 2022, 6:49 PM
Lydia_Pintscher moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.
Lydia_Pintscher moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Dec 5 2022, 3:37 PM
Lydia_Pintscher moved this task from Unified DOT Backlog to Product Backlog on the Wikidata Dev Team board.
Lucas_Werkmeister_WMDE claimed this task.Dec 5 2022, 3:54 PM
Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Doing on the Wikidata Dev Team (Sprint-∞) board.
gerritbot added a comment.Dec 5 2022, 5:48 PM

Change 864798 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Simplify MultilingualTextViolationMessageRenderer

https://gerrit.wikimedia.org/r/864798

gerritbot added a project: Patch-For-Review.Dec 5 2022, 5:48 PM

Change 864799 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Inject LanguageNameUtils into ViolationMessageRenderer(Factory)

https://gerrit.wikimedia.org/r/864799

gerritbot added a comment.Dec 5 2022, 5:48 PM

Change 864800 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Add strict types to ViolationMessageRenderer

https://gerrit.wikimedia.org/r/864800

gerritbot added a comment.Dec 5 2022, 5:48 PM

Change 864801 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Move MessageLocalizer in ViolationMessageRendererFactory

https://gerrit.wikimedia.org/r/864801

gerritbot added a comment.Dec 5 2022, 5:48 PM

Change 864802 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Move ViolationMessageRendererFactory to service container

https://gerrit.wikimedia.org/r/864802

gerritbot added a comment.Dec 5 2022, 5:48 PM

Change 864803 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessageRendererFactory in SpecialConstraintReport

https://gerrit.wikimedia.org/r/864803

gerritbot added a comment.Dec 5 2022, 5:48 PM

Change 864804 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Format language constraint parameters in user language

https://gerrit.wikimedia.org/r/864804

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Dec 5 2022, 5:49 PM
In T316936#8443909, @gerritbot wrote:

Change 864804 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Format language constraint parameters in user language

https://gerrit.wikimedia.org/r/864804

This change actually implements the task, the rest of the changes are preparation and related cleanup.

gerritbot added a comment.Dec 7 2022, 12:33 PM

Change 864798 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Simplify MultilingualTextViolationMessageRenderer

https://gerrit.wikimedia.org/r/864798

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 7 2022, 1:01 PM
gerritbot added a comment.Dec 9 2022, 11:15 AM

Change 864799 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Inject LanguageNameUtils into ViolationMessageRenderer(Factory)

https://gerrit.wikimedia.org/r/864799

gerritbot added a comment.Dec 9 2022, 11:16 AM

Change 864800 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Add strict types to ViolationMessageRenderer

https://gerrit.wikimedia.org/r/864800

gerritbot added a comment.Dec 9 2022, 12:39 PM

Change 864801 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Move MessageLocalizer in ViolationMessageRendererFactory

https://gerrit.wikimedia.org/r/864801

gerritbot added a comment.Dec 9 2022, 12:40 PM

Change 864802 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Move ViolationMessageRendererFactory to service container

https://gerrit.wikimedia.org/r/864802

gerritbot added a comment.Dec 9 2022, 12:43 PM

Change 864803 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessageRendererFactory in SpecialConstraintReport

https://gerrit.wikimedia.org/r/864803

gerritbot added a comment.Dec 9 2022, 12:43 PM

Change 864804 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Format language constraint parameters in user language

https://gerrit.wikimedia.org/r/864804

Lucas_Werkmeister_WMDE moved this task from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board.Dec 9 2022, 12:46 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 9 2022, 1:30 PM
Arian_Bozorg subscribed.Dec 19 2022, 11:40 AM

Thanks Lucas :)

All looks good from my end

Arian_Bozorg closed this task as Resolved.Dec 19 2022, 11:40 AM
Arian_Bozorg reopened this task as Open.Dec 19 2022, 11:42 AM
Arian_Bozorg closed this task as Resolved.Dec 19 2022, 11:45 AM
Arian_Bozorg moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.
karapayneWMDE moved this task from Our work done to 2022 Completed Tasks on the Wikidata Dev Team (Sprint-∞) board.Dec 20 2022, 8:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy