Get Jest to run in PageTriage continuous integration
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Novem_Linguae
	Apr 27 2023, 10:22 PM

Description

Get Jest (JavaScript unit test library) to run in PageTriage continuous integration

Now that https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/910002 (make jest available for unit tests) is merged.

The documentation at https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Adding_a_MediaWiki_extension#Editing_Zuul_configuration may be helpful. Looks like a patch may be needed for integration/config -> zuul/layout.yaml

Related Objects

Mentioned Here: T334642: Investigate switching Javascript unit tests from QUnit to Jest [12hrs]

Event Timeline

Novem_Linguae created this task.Apr 27 2023, 10:22 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 27 2023, 10:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Novem_Linguae moved this task from Backlog to Priority technical debt on the PageTriage board.Apr 27 2023, 10:22 PM

I think most extensions handle this by updating the package.json to look like this:

"scripts": {
		"test": "grunt test && npm run jest",
		"jest": "jest",
	},

But since jest currently exits with error code 1 (no tests) we would need to wait before doing that.

EDIT: We could change the jest definition to jest --passWithNoTests" and then it should start to work in CI, and as tests are added, they should run.

Sgs moved this task from Inbox to Triaged on the Growth-Team board.Apr 28 2023, 2:03 PM

jsn.sherman changed the task status from Open to In Progress.Jun 20 2023, 1:43 PM

jsn.sherman added a project: Moderator-Tools-Team (Kanban).

jsn.sherman moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.

jsn.sherman moved this task from Eng review to Done on the Moderator-Tools-Team (Kanban) board.Jun 20 2023, 3:51 PM

Since this didn't get picked up, patch is at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/930781

Samwalton9-WMF closed this task as Resolved.Jun 30 2023, 11:31 AM

Samwalton9-WMF claimed this task.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Get Jest to run in PageTriage continuous integrationClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Get Jest to run in PageTriage continuous integration
Closed, ResolvedPublic
Actions