fix(lsp): add missing checks for capability dynamic registration support (#6643)

skewb1k · ematipico · web-flow · commit df15ad6e9a99 · 2025-06-30T17:12:44.000+01:00
Co-authored-by: ematipico &lt;602478+ematipico@users.noreply.github.com&gt;
diff --git a/.changeset/fix_capabilities_dynamic_registration.md b/.changeset/fix_capabilities_dynamic_registration.md
@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#4994]([https://github.com/biomejs/biome/discussions/4994). LSP server registered some capabilities even when the client did not support dynamic registration.
diff --git a/crates/biome_lsp/src/server.rs b/crates/biome_lsp/src/server.rs
@@ -121,6 +121,9 @@ impl LSPServer {
     async fn setup_capabilities(&self) {
         let mut capabilities = CapabilitySet::default();
 
+        let is_linting_and_formatting_disabled = self.session.is_linting_and_formatting_disabled();
+        debug!("Requires configuration: {is_linting_and_formatting_disabled}");
+
         capabilities.add_capability(
             "biome_did_change_extension_settings",
             "workspace/didChangeConfiguration",
@@ -193,7 +196,7 @@ impl LSPServer {
         capabilities.add_capability(
             "biome_formatting",
             "textDocument/formatting",
-            if self.session.is_linting_and_formatting_disabled() {
+            if is_linting_and_formatting_disabled || !self.session.can_register_formatting() {
                 CapabilityStatus::Disable
             } else {
                 CapabilityStatus::Enable(None)
@@ -202,7 +205,7 @@ impl LSPServer {
         capabilities.add_capability(
             "biome_range_formatting",
             "textDocument/rangeFormatting",
-            if self.session.is_linting_and_formatting_disabled() {
+            if is_linting_and_formatting_disabled || !self.session.can_register_range_formatting() {
                 CapabilityStatus::Disable
             } else {
                 CapabilityStatus::Enable(None)
@@ -211,7 +214,8 @@ impl LSPServer {
         capabilities.add_capability(
             "biome_on_type_formatting",
             "textDocument/onTypeFormatting",
-            if self.session.is_linting_and_formatting_disabled() {
+            if is_linting_and_formatting_disabled || !self.session.can_register_on_type_formatting()
+            {
                 CapabilityStatus::Disable
             } else {
                 CapabilityStatus::Enable(Some(json!(DocumentOnTypeFormattingRegistrationOptions {
@@ -222,12 +226,10 @@ impl LSPServer {
             },
         );
 
-        let f = self.session.is_linting_and_formatting_disabled();
-        debug!("Requires configuration: {f}");
         capabilities.add_capability(
             "biome_code_action",
             "textDocument/codeAction",
-            if self.session.is_linting_and_formatting_disabled() {
+            if is_linting_and_formatting_disabled || !self.session.can_register_code_action() {
                 CapabilityStatus::Disable
             } else {
                 CapabilityStatus::Enable(Some(json!(CodeActionProviderCapability::from(
diff --git a/crates/biome_lsp/src/session.rs b/crates/biome_lsp/src/session.rs
@@ -507,6 +507,48 @@ impl Session {
         result
     }
 
+    #[instrument(level = "info", skip(self))]
+    pub(crate) fn can_register_on_type_formatting(&self) -> bool {
+        let result = self
+            .initialize_params
+            .get()
+            .and_then(|c| c.client_capabilities.text_document.as_ref())
+            .and_then(|c| c.on_type_formatting)
+            .and_then(|c| c.dynamic_registration)
+            == Some(true);
+
+        info!("Can register onTypeFormatting: {result}");
+        result
+    }
+
+    #[instrument(level = "info", skip(self))]
+    pub(crate) fn can_register_formatting(&self) -> bool {
+        let result = self
+            .initialize_params
+            .get()
+            .and_then(|c| c.client_capabilities.text_document.as_ref())
+            .and_then(|c| c.formatting)
+            .and_then(|c| c.dynamic_registration)
+            == Some(true);
+
+        info!("Can register formatting: {result}");
+        result
+    }
+
+    #[instrument(level = "info", skip(self))]
+    pub(crate) fn can_register_range_formatting(&self) -> bool {
+        let result = self
+            .initialize_params
+            .get()
+            .and_then(|c| c.client_capabilities.text_document.as_ref())
+            .and_then(|c| c.range_formatting)
+            .and_then(|c| c.dynamic_registration)
+            == Some(true);
+
+        info!("Can register rangeFormatting: {result}");
+        result
+    }
+
     #[instrument(level = "info", skip(self))]
     pub(crate) fn can_register_did_change_watched_files(&self) -> bool {
         let result = self
@@ -521,6 +563,20 @@ impl Session {
         result
     }
 
+    #[instrument(level = "info", skip(self))]
+    pub(crate) fn can_register_code_action(&self) -> bool {
+        let result = self
+            .initialize_params
+            .get()
+            .and_then(|c| c.client_capabilities.text_document.as_ref())
+            .and_then(|c| c.code_action.as_ref())
+            .and_then(|c| c.dynamic_registration)
+            == Some(true);
+
+        info!("Can register codeAction: {result}");
+        result
+    }
+
     /// Get the current workspace folders
     pub(crate) fn get_workspace_folders(&self) -> Option<&Vec<WorkspaceFolder>> {
         self.initialize_params

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@biomejs/biome": patch
 +---
++
 +Fixed [#4994]([https://github.com/biomejs/biome/discussions/4994). LSP server registered some capabilities even when the client did not support dynamic registration.