Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update algolia referrer #19114

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

harish-sethuraman
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: referrer addition for algolia

What changes did you make? (Give an overview)

@harish-sethuraman harish-sethuraman requested a review from a team as a code owner November 7, 2024 06:04
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Nov 7, 2024
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 242fac2
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/672c585d724a2200086a154d
😎 Deploy Preview https://deploy-preview-19114--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for 2nd approval.

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 0da3f73 into main Nov 7, 2024
27 checks passed
@aladdin-add aladdin-add deleted the chore/update-algolia-referrer branch November 7, 2024 09:19
@nzakas
Copy link
Member

nzakas commented Nov 7, 2024

We also need to do this on the v8.x branch. Anyone up for that?

@harish-sethuraman
Copy link
Member Author

Do I send a pr to that branch or it has direct push access? I’ll do it

@nzakas
Copy link
Member

nzakas commented Nov 7, 2024

Send a PR to that branch. It's protected like main

@mdjermanovic
Copy link
Member

We also need to do this on the v8.x branch.

This isn't finished yet?

@amareshsm
Copy link
Member

We also need to do this on the v8.x branch.

This isn't finished yet?

No yet. @harish-sethuraman Need to do the same on the v8.x branch would you like to take it?

aladdin-add pushed a commit that referenced this pull request Nov 26, 2024
aladdin-add pushed a commit that referenced this pull request Nov 26, 2024
@aladdin-add
Copy link
Member

no worries - the PR is #19178.

mdjermanovic pushed a commit that referenced this pull request Nov 26, 2024
chore: update algolia referrer (#19114)

Co-authored-by: Strek <ssharishkumar@gmail.com>
@harish-sethuraman
Copy link
Member Author

sorry missed it my bad, Thanks Aladdin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy