-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update algolia referrer #19114
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Waiting for 2nd approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
We also need to do this on the v8.x branch. Anyone up for that? |
Do I send a pr to that branch or it has direct push access? I’ll do it |
Send a PR to that branch. It's protected like |
This isn't finished yet? |
No yet. @harish-sethuraman Need to do the same on the v8.x branch would you like to take it? |
no worries - the PR is #19178. |
chore: update algolia referrer (#19114) Co-authored-by: Strek <ssharishkumar@gmail.com>
sorry missed it my bad, Thanks Aladdin! |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: referrer addition for algolia
What changes did you make? (Give an overview)