Skip to content

Handle missing caller identifier #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

Handle missing caller identifier #3036

merged 1 commit into from
Feb 27, 2025

Conversation

jnyrup
Copy link
Member

@jnyrup jnyrup commented Feb 27, 2025

Fixes #3031
Regression from #3000 where previously getCallerIdentifier() + callerPostfix would return an empty string.
See https://github.com/fluentassertions/fluentassertions/pull/3000/files#diff-f1890f45abb0a4df9c59f857aff667980d90f2c1ece7ea0f12e5dd85590ae8ccL105

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@jnyrup
Handle missing caller identifier
541af3b 
Fixes fluentassertions#3031
Regression from fluentassertions#3000 where previously `getCallerIdentifier() + callerPostfix` would return an empty string.
@github-actions GitHub Actions
Copy link

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13571990164

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 97.418%
Totals Coverage Status
Change from base Build 13503995576: -0.01%
Covered Lines: 12326
Relevant Lines: 12510
💛 - Coveralls

@jnyrup jnyrup added the bug label Feb 27, 2025
@jnyrup jnyrup merged commit 669f817 into fluentassertions:main Feb 27, 2025
8 checks passed
@jnyrup jnyrup deleted the issue3031 branch February 27, 2025 20:08
@jnyrup jnyrup mentioned this pull request Feb 27, 2025
Closed
7 tasks
@dennisdoomen dennisdoomen added this to the 8.2.0 milestone Mar 14, 2025
This was referenced Jul 21, 2025
Open
Closed
Closed
Closed
Open
Open
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.

Get a NullReferenceException when using tracing with equivalency assertions
3 participants
@jnyrup @coveralls @dennisdoomen
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy