Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.23.7
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.23.8
Choose a head ref
  • 7 commits
  • 17 files changed
  • 6 contributors

Commits on Mar 4, 2025

  1. [release-branch.go1.23] all: updates vendored x/net

    This is to update module version to the fixed x/net.
    
    For #71984
    
    Change-Id: I8f4357f14a7d44a782c131eb856b50a103be2f2d
    Reviewed-on: https://go-review.googlesource.com/c/go/+/654796
    Reviewed-by: Junyang Shao <shaojunyang@google.com>
    Auto-Submit: Junyang Shao <shaojunyang@google.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    JunyangShao authored and gopherbot committed Mar 4, 2025
    Configuration menu
    Copy the full SHA
    45aade7 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2025

  1. [release-branch.go1.23] net/http: reject newlines in chunk-size lines

    Unlike request headers, where we are allowed to leniently accept
    a bare LF in place of a CRLF, chunked bodies must always use CRLF
    line terminators. We were already enforcing this for chunk-data lines;
    do so for chunk-size lines as well. Also reject bare CRs anywhere
    other than as part of the CRLF terminator.
    
    Fixes CVE-2025-22871
    Fixes #72010
    For #71988
    
    Change-Id: Ib0e21af5a8ba28c2a1ca52b72af8e2265ec79e4a
    Reviewed-on: https://go-review.googlesource.com/c/go/+/652998
    Reviewed-by: Jonathan Amsterdam <jba@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    (cherry picked from commit d31c805)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/657216
    neild authored and cherrymui committed Mar 17, 2025
    Configuration menu
    Copy the full SHA
    15e01a2 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2025

  1. [release-branch.go1.23] internal/godebugs: fix changed version for wi…

    …nsymlink and winreadlinkvolume to 1.23
    
    https://go.dev/doc/godebug#go-123 documents changes to winsymlink and
    winreadlinkvolume in Go 1.23.
    
    This fixes the registered "changed" minor version to Go 1.23,
    so that defaults when building a Go 1.22 module are correct.
    
    Fixes #72937
    
    Change-Id: I5d5bf31ca04f9e95208fb0fdaad2232f9db653ff
    Reviewed-on: https://go-review.googlesource.com/c/go/+/659035
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    (cherry picked from commit 2e749a6)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/658976
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    liggitt authored and gopherbot committed Mar 24, 2025
    Configuration menu
    Copy the full SHA
    ec6e84d View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2025

  1. [release-branch.go1.23] runtime: only set isExtraInC if there are no …

    …Go frames left
    
    mp.isExtraInC is intended to indicate that this M has no Go frames at
    all; it is entirely executing in C.
    
    If there was a cgocallback to Go and then a cgocall to C, such that the
    leaf frames are C, that is fine. e.g., traceback can handle this fine
    with SetCgoTraceback (or by simply skipping the C frames).
    
    However, we currently mismanage isExtraInC, unconditionally setting it
    on return from cgocallback. This means that if there are two levels of
    cgocallback, we end up running Go code with isExtraInC set.
    
    1. C-created thread calls into Go function 1 (via cgocallback).
    2. Go function 1 calls into C function 1 (via cgocall).
    3. C function 1 calls into Go function 2 (via cgocallback).
    4. Go function 2 returns back to C function 1 (returning via the remainder of cgocallback).
    5. C function 1 returns back to Go function 1 (returning via the remainder of cgocall).
    6. Go function 1 is now running with mp.isExtraInC == true.
    
    The fix is simple; only set isExtraInC on return from cgocallback if
    there are no more Go frames. There can't be more Go frames unless there
    is an active cgocall out of the Go frames.
    
    For #72870.
    Fixes #72871.
    
    Cq-Include-Trybots: luci.golang.try:go1.23-linux-amd64-longtest
    Change-Id: I6a6a636c4e7ba75a29639d7036c5af3738033467
    Reviewed-on: https://go-review.googlesource.com/c/go/+/658035
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    Commit-Queue: Michael Pratt <mpratt@google.com>
    Auto-Submit: Michael Pratt <mpratt@google.com>
    Reviewed-by: Michael Knyszek <mknyszek@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    (cherry picked from commit 577bb3d)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/658055
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    prattmic authored and gopherbot committed Mar 25, 2025
    Configuration menu
    Copy the full SHA
    c855149 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.23] runtime: skip TestCgoCallbackPprof on platfor…

    …ms with broken profiling
    
    CL 658035 added TestCgoCallbackPprof, which is consistently failing on
    solaris. runtime/pprof maintains a list of platforms where CPU profiling
    does not work properly. Since this test requires CPU profiling, skip the
    this test on those platforms.
    
    For #72870.
    For #72876.
    For #72871.
    
    Change-Id: I6a6a636cbf6b16abcbba8771178fe1d001be9d9b
    Reviewed-on: https://go-review.googlesource.com/c/go/+/658415
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Michael Pratt <mpratt@google.com>
    Reviewed-by: Michael Knyszek <mknyszek@google.com>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/658435
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    TryBot-Bypass: Dmitri Shuralyov <dmitshur@google.com>
    prattmic authored and gopherbot committed Mar 25, 2025
    Configuration menu
    Copy the full SHA
    2c0a0fc View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2025

  1. [release-branch.go1.23] runtime: explicitly disable async preempt for…

    … internal/runtime
    
    Fixes #72114
    For #71591
    Relevant CL 560155
    
    Change-Id: Iebc497d56b36d50c13a6dd88e7bca4578a03cf63
    Reviewed-on: https://go-review.googlesource.com/c/go/+/654916
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    Auto-Submit: Michael Pratt <mpratt@google.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    (cherry picked from commit 92a63bd)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/660935
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    panjf2000 authored and gopherbot committed Mar 26, 2025
    Configuration menu
    Copy the full SHA
    c72a2ba View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2025

  1. [release-branch.go1.23] go1.23.8

    Change-Id: Ied6ade315672e373b9b861f09ee0feba4fb8030b
    Reviewed-on: https://go-review.googlesource.com/c/go/+/662057
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Carlos Amedee <carlos@golang.org>
    gopherbot committed Apr 1, 2025
    Configuration menu
    Copy the full SHA
    7a2cfb7 View commit details
    Browse the repository at this point in the history
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy