Skip to content

Create JupyterLab 3.4.4 accessibility statement #14856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 2, 2023
Merged

Create JupyterLab 3.4.4 accessibility statement #14856

merged 3 commits into from
Aug 2, 2023

Conversation

isabela-pf
Copy link
Contributor

This PR adds an accessibility statement for JupyterLab 3.4.4 to the JupyterLab documentation. This is the same statement as has been on jupyter/accessibility documentation for some time now, barring formatting changes made to make this fit within the existing JupyterLab docs.

Please note that the version number the review applies to is not the most current release. Since many users do not update versions immediately, I've been asked to contribute this as it will still be relevant to our community (users and contributors and decision makers).

As always, review is welcome. I'll answer questions to the best of my ability, so thanks in advance for giving this a bit of your time. 🌻

References

There is no issue on JupyterLab singularly for adding an accessibility statement.

#14396's request for user-facing accessibility documentation is the closest. #9399's review is also referenced, and many of the issues persisted even though this statement was made for a more recent version.

Code changes

This adds a new page to the Getting Started documentation and adds an accessibility section to the Getting Started table of contents.

User-facing changes

Users in the JupyterLab documentation will find a new section of Getting Started and a new page with a JupyterLab accessibility statement.

Backwards-incompatible changes

There are no backwards incompatible changes I am aware of.

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@isabela-pf isabela-pf mentioned this pull request Jul 20, 2023
Closed
@fcollonval fcollonval modified the milestones: 4.0.x, 3.6.x Jul 20, 2023
fcollonval
fcollonval approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @isabela-pf

@isabela-pf isabela-pf mentioned this pull request Jul 27, 2023
Closed
krassowski
krassowski reviewed Jul 29, 2023
View reviewed changes
@isabela-pf @krassowski
Update docs/source/getting_started/accessibility.rst
694d42c 
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@fcollonval fcollonval merged commit 816d4bb into jupyterlab:main Aug 2, 2023
@fcollonval
Copy link
Member

@meeseeksdev please backport to 4.0.x

@meeseeksmachine meeseeksmachine mentioned this pull request Aug 2, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Aug 2, 2023
@isabela-pf @meeseeksmachine
Backport PR jupyterlab#14856: Create JupyterLab 3.4.4 accessibility s…
ba257b7 
…tatement
@fcollonval
Copy link
Member

@meeseeksdev please backport to 3.6.x

@lumberbot-app
Copy link

lumberbot-app bot commented Aug 2, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 816d4bb471f043ab621635b2633eaf330be0bc72
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #14856: Create JupyterLab 3.4.4 accessibility statement'
  1. Push to a named branch:
git push YOURFORK 3.6.x:auto-backport-of-pr-14856-on-3.6.x
  1. Create a PR against branch 3.6.x, I would have named this PR:

"Backport PR #14856 on branch 3.6.x (Create JupyterLab 3.4.4 accessibility statement)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

fcollonval pushed a commit that referenced this pull request Aug 3, 2023
@meeseeksmachine @isabela-pf
Backport PR #14856: Create JupyterLab 3.4.4 accessibility statement (#…
ab47148 
…14906)

Co-authored-by: Isabela Presedo-Floyd <50221806+isabela-pf@users.noreply.github.com>
@isabela-pf
Copy link
Contributor Author

Thank you @fcollonval and @krassowski! 🌻

fcollonval pushed a commit to fcollonval/jupyterlab that referenced this pull request Aug 11, 2023
@isabela-pf @fcollonval
Backport PR jupyterlab#14856: Create JupyterLab 3.4.4 accessibility s…
378fea0 
…tatement
@fcollonval fcollonval mentioned this pull request Aug 11, 2023
Merged
fcollonval pushed a commit to fcollonval/jupyterlab that referenced this pull request Aug 11, 2023
@isabela-pf @fcollonval
Backport PR jupyterlab#14856: Create JupyterLab 3.4.4 accessibility s…
3ad1653 
…tatement
fcollonval added a commit that referenced this pull request Aug 13, 2023
@fcollonval @isabela-pf
Backport PR #14856: Create JupyterLab 3.4.4 accessibility statement (#…
09f090e 
…14958)

Co-authored-by: Isabela Presedo-Floyd <50221806+isabela-pf@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krassowski krassowski krassowski left review comments

@fcollonval fcollonval fcollonval approved these changes

Assignees

@isabela-pf isabela-pf

Labels
documentation tag:Accessibility
Projects
None yet
Milestone
3.6.x
Development

Successfully merging this pull request may close these issues.
3 participants
@isabela-pf @fcollonval @krassowski
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy