Skip to content

Commit cccb15d

Browse files
joyeecheungaduh95
authored andcommitted
test: skip wasm-allocation tests for pointer compression builds
V8 isolate group initialization forces allocation of the virtual memory cage with pointer compression builds and simply would not work when there is a smaller hard limit on the virtual memory. PR-URL: #58171 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 3f954ac commit cccb15d

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

test/wasm-allocation/wasm-allocation.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@ prefix wasm-allocation
66

77
[true] # This section applies to all platforms
88

9-
[$system!=linux || $asan==on]
9+
[$system!=linux || $asan==on || $pointer_compression==on]
1010
test-wasm-allocation: SKIP

tools/test.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1619,6 +1619,9 @@ def get_asan_state(vm, context):
16191619
asan = Execute([vm, '-p', 'process.config.variables.asan'], context).stdout.strip()
16201620
return "on" if asan == "1" else "off"
16211621

1622+
def get_pointer_compression_state(vm, context):
1623+
pointer_compression = Execute([vm, '-p', 'process.config.variables.v8_enable_pointer_compression'], context).stdout.strip()
1624+
return "on" if pointer_compression == "1" else "off"
16221625

16231626
def Main():
16241627
parser = BuildOptions()
@@ -1717,6 +1720,7 @@ def Main():
17171720
'arch': vmArch,
17181721
'type': get_env_type(vm, options.type, context),
17191722
'asan': get_asan_state(vm, context),
1723+
'pointer_compression': get_pointer_compression_state(vm, context),
17201724
}
17211725
test_list = root.ListTests([], path, context, arch, mode)
17221726
unclassified_tests += test_list

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy