Skip to content

fix(nextjs): add eslint plugin dependencies in application and library generators #30592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Apr 2, 2025

Current Behavior

Currently, eslint-config-next which is a next package requires @nx/eslint-plugin-next
Also when you create a next application from create-nx-workspace you get neither swc nor babelrc which is unintended.

Expected Behavior

When you create a next application OOTB with jest and linting they should work without issues.

Related Issue(s)

Fixes #26823

@ndcunningham ndcunningham self-assigned this Apr 2, 2025
@ndcunningham ndcunningham requested a review from a team as a code owner April 2, 2025 16:27
@ndcunningham ndcunningham requested a review from Coly010 April 2, 2025 16:27
Copy link

vercel bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2025 5:36pm

Copy link
Contributor

nx-cloud bot commented Apr 2, 2025

View your CI Pipeline Execution ↗ for commit a0575a9.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 24m 34s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 19s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=27b78... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 1m 19s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-02 18:04:30 UTC

@ndcunningham ndcunningham changed the title fix(nextjs): add nx version and eslint plugin dependencies in application and library generators fix(nextjs): add eslint plugin dependencies in application and library generators Apr 2, 2025
@ndcunningham ndcunningham force-pushed the fix/next-jest-setup branch from eb7b87c to 42b9a04 Compare April 2, 2025 17:29
…d library generators and normalize swc Option

closes: #26823
@ndcunningham ndcunningham force-pushed the fix/next-jest-setup branch from 42b9a04 to a0575a9 Compare April 2, 2025 17:34
@ndcunningham ndcunningham enabled auto-merge (squash) April 2, 2025 17:54
@ndcunningham ndcunningham merged commit 6e50a01 into master Apr 2, 2025
13 checks passed
@ndcunningham ndcunningham deleted the fix/next-jest-setup branch April 2, 2025 18:04
Copy link

github-actions bot commented Apr 8, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error occurred while processing files for the @nx/jest/plugin plugin.
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy