fix(nuxt): generate correct types for async data defaults based on nuxt.config
#32324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the generation of types for async data defaults to correctly use the configured values when v4 compatibility mode is enabled.
- Updated the type generation logic in Nuxt templates for async data and error value defaults based on nuxt.config settings.
- Introduced nested ternary expressions to select between null and undefined for v4 compatibility.
Comments suppressed due to low confidence (1)
packages/nuxt/src/core/templates.ts:108
- In non-v4 mode, the default now returns 'undefined' instead of the previous 'null'. Please verify that this behavior aligns with the intended API design.
type DefaultAsyncDataErrorValue = ${ isV4 ? ctx.nuxt.options.experimental.defaults.useAsyncData.errorValue === 'null' ? null : undefined : undefined }
packages/nuxt/src/core/templates.ts
Outdated
Comment on lines
106
to
114
| return ` | ||
| declare module 'nuxt/app/defaults' { | ||
| type DefaultAsyncDataErrorValue = ${isV4 ? 'undefined' : 'null'} | ||
| type DefaultAsyncDataValue = ${isV4 ? 'undefined' : 'null'} | ||
| type DefaultAsyncDataErrorValue = ${ | ||
| isV4 | ||
| ? ctx.nuxt.options.experimental.defaults.useAsyncData.errorValue === 'null' | ||
| ? null | ||
| : undefined | ||
| : undefined | ||
| } |
There was a problem hiding this comment.
[nitpick] The nested ternary operator here reduces readability; consider refactoring by extracting the logic into a helper or using clearer conditional constructs.
Copilot uses AI. Check for mistakes.
@nuxt/kit
nuxt
@nuxt/rspack-builder
@nuxt/schema
@nuxt/vite-builder
@nuxt/webpack-builder
commit: |
CodSpeed Performance ReportMerging #32324 will not alter performanceComparing Summary
|
danielroe
reviewed
Jun 10, 2025
OrbisK
reviewed
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #32213
📚 Description
Correctly generates types for chosen async data/data error value when v4 compat mode is enabled.