Skip to content

fix: write allow-build value to pnpm-workspace.yaml #9404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2025
Merged

fix: write allow-build value to pnpm-workspace.yaml #9404

merged 3 commits into from
Apr 14, 2025

Conversation

btea
Copy link
Member

@btea btea commented Apr 11, 2025

close #9399

@btea btea requested a review from zkochan as a code owner April 11, 2025 14:48
@zkochan
Copy link
Member

zkochan commented Apr 12, 2025

A test should be updated.

@btea
Copy link
Member Author

btea commented Apr 13, 2025

Which test case should I update? Without seeing a clear error message, I can't be sure.

@zkochan
Copy link
Member

zkochan commented Apr 13, 2025

There is an error message:

  Summary of all failing tests
  FAIL test/install/lifecycleScripts.ts (16.945 s)
    ● selectively allow scripts in some dependencies by --allow-build flag
  
      expect(received).toStrictEqual(expected) // deep equality
  
      Expected: ["@pnpm.e2e/install-script-example"]
      Received: undefined
  
        184 |
        185 |   const manifest = loadJsonFile.sync<ProjectManifest>('package.json')
      > 186 |   expect(manifest.pnpm?.onlyBuiltDependencies).toStrictEqual(['@pnpm.e2e/install-script-example'])
            |                                                ^
        187 | })
        188 |
        189 | test('selectively allow scripts in some dependencies by --allow-build flag overlap ignoredBuiltDependencies', async () => {
  
        at Object.<anonymous> (test/install/lifecycleScripts.ts:186:48)
  
  
  Test Suites: 1 failed, 2 skipped, 42 passed, 43 of 45 total
  Tests:       1 failed, 6 skipped, 302 passed, 309 total

@btea
Copy link
Member Author

btea commented Apr 13, 2025

Thank you for your clear reply.

When ci fails, it only displays the exit code, but no clear error message. Sometimes it will be affected by other errors locally.

Is there any configuration that can make CI give clear error messages? 🤔

@MikeMcC399

This comment was marked as resolved.

Sign in to view
@zkochan
Copy link
Member

zkochan commented Apr 14, 2025

When ci fails, it only displays the exit code, but no clear error message. Sometimes it will be affected by other errors locally.

The error is there but you need to expand the output of the previous package's test output.

@zkochan zkochan changed the title fix: writting allow-build value to pnpm-workspace.yaml fix: write allow-build value to pnpm-workspace.yaml Apr 14, 2025
@zkochan zkochan merged commit 4d95e93 into pnpm:main Apr 14, 2025
8 of 9 checks passed
@btea btea deleted the fix/allow-build-write-config-to-pnpm-workspace branch April 14, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkochan zkochan zkochan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--allow-build still writes onlyBuiltDependencies to package.json
3 participants
@btea @zkochan @MikeMcC399
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy