-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
replace undefined with void 0 for operator void #5838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#chore/tweak-unary-expression Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
Performance report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5838 +/- ##
=======================================
Coverage 98.53% 98.53%
=======================================
Files 269 269
Lines 8547 8547
Branches 1467 1466 -1
=======================================
Hits 8422 8422
Misses 93 93
Partials 32 32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
This PR has been released as part of rollup@4.34.6. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
related #5775
Description
Replace
undefined
withvoid 0
in unary expressions using the void operator. This way, we can preserve the original shape of the source code, because some people prefer usingvoid 0
instead ofundefined
in their code.