Skip to content

replace undefined with void 0 for operator void #5838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Feb 7, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
related #5775

Description

Replace undefined with void 0 in unary expressions using the void operator. This way, we can preserve the original shape of the source code, because some people prefer using void 0 instead of undefined in their code.

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 0:57am

Copy link

github-actions bot commented Feb 7, 2025

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#chore/tweak-unary-expression

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-m6sfmo8le-rollup-js.vercel.app/repl/?pr=5838

Copy link

github-actions bot commented Feb 7, 2025

Performance report

  • BUILD: 7276ms, 749 MB
    • initialize: 0ms, 28.1 MB
    • generate module graph: 2815ms, 558 MB
      • generate ast: 1285ms, 552 MB
    • sort and bind modules: 405ms, 602 MB
    • mark included statements: 4061ms, 749 MB
      • treeshaking pass 1: 2411ms, 742 MB
      • treeshaking pass 2: 469ms, 746 MB
      • treeshaking pass 3: 406ms, 746 MB
      • treeshaking pass 4: 391ms, 746 MB
      • treeshaking pass 5: 391ms, 749 MB
  • GENERATE: 741ms, 986 MB
    • initialize render: 0ms, 883 MB
    • generate chunks: 75ms, 893 MB
      • optimize chunks: 0ms, 889 MB
    • render chunks: 646ms, 964 MB
    • transform chunks: 17ms, 986 MB
    • generate bundle: 0ms, 986 MB

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (18cc314) to head (f9fcd46).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5838   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         269      269           
  Lines        8547     8547           
  Branches     1467     1466    -1     
=======================================
  Hits         8422     8422           
  Misses         93       93           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@lukastaegert lukastaegert added this pull request to the merge queue Feb 7, 2025
Merged via the queue into master with commit fe89821 Feb 7, 2025
41 checks passed
@lukastaegert lukastaegert deleted the chore/tweak-unary-expression branch February 7, 2025 16:01
Copy link

github-actions bot commented Feb 7, 2025

This PR has been released as part of rollup@4.34.6. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy