-
-
Notifications
You must be signed in to change notification settings - Fork 270
Comparing changes
Open a pull request
base repository: rubocop/rubocop-rails
base: v2.30.0
head repository: rubocop/rubocop-rails
compare: v2.30.1
- 8 commits
- 6 files changed
- 1 contributor
Commits on Feb 15, 2025
-
Configuration menu - View commit details
-
Copy full SHA for ddc7e4b - Browse repository at this point
Copy the full SHA ddc7e4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 405faca - Browse repository at this point
Copy the full SHA 405facaView commit details
Commits on Feb 16, 2025
-
Fix an incorrect behavior when using
AllCops: MigratedSchemaVersion
This PR fixes an incorrect behavior when using `AllCops: MigratedSchemaVersion`. This suppresses the following warning when `MigratedSchemaVersion` is defined on the user side: ```console $ bundle exec rubocop (snip) Warning: AllCops does not support MigratedSchemaVersion parameter. Supported parameters are: - RubyInterpreters - Include - Exclude - DefaultFormatter - DisplayCopNames - DisplayStyleGuide - StyleGuideBaseURL - DocumentationBaseURL - DocumentationExtension - ExtraDetails - StyleGuideCopsOnly - EnabledByDefault - DisabledByDefault - NewCops - UseCache - MaxFilesInCache - CacheRootDirectory - AllowSymlinksInCacheRootDirectory - TargetRubyVersion - ParserEngine - SuggestExtensions - ActiveSupportExtensionsEnabled - StringLiteralsFrozenByDefault ``` The default value of `AllCops: MigratedSchemaVersion` in `config/default.yml` will change from `null` to the UNIX epoch time, but typically, there should be no migration files older than the UNIX epoch time. This is a bug fix related to the plugin migration in #1434.
Configuration menu - View commit details
-
Copy full SHA for d40c943 - Browse repository at this point
Copy the full SHA d40c943View commit details -
[Fix #1442] Fix an incorrect behavior when using `AllCops: TargetRail…
…sVersion` This PR fixes an incorrect behavior when using `AllCops: TargetRailsVersion`. This suppresses the following warning when `TargetRailsVersion` is defined on the user side: ```console $ bundle exec rubocop (snip) Warning: AllCops does not support TargetRailsVersion parameter. Supported parameters are: - RubyInterpreters - Include - Exclude - DefaultFormatter - DisplayCopNames - DisplayStyleGuide - StyleGuideBaseURL - DocumentationBaseURL - DocumentationExtension - ExtraDetails - StyleGuideCopsOnly - EnabledByDefault - DisabledByDefault - NewCops - UseCache - MaxFilesInCache - CacheRootDirectory - AllowSymlinksInCacheRootDirectory - TargetRubyVersion - ParserEngine - SuggestExtensions - ActiveSupportExtensionsEnabled - StringLiteralsFrozenByDefault ``` This is a dirty hack relying on a private constant to prevent the warning. It should be updated to a better design in the future. Fixes #1442.
Configuration menu - View commit details
-
Copy full SHA for da9d36f - Browse repository at this point
Copy the full SHA da9d36fView commit details
Commits on Feb 17, 2025
-
Merge pull request #1444 from koic/fix_an_incorrect_behavior_when_usi…
…ng_migrated_schema_version Fix an incorrect behavior when using `AllCops: MigratedSchemaVersion`
Configuration menu - View commit details
-
Copy full SHA for d8bb510 - Browse repository at this point
Copy the full SHA d8bb510View commit details -
Merge pull request #1445 from koic/fix_an_error_when_using_target_rai…
…ls_version [Fix #1442] Fix an incorrect behavior when using `AllCops: TargetRailsVersion`
Configuration menu - View commit details
-
Copy full SHA for 063bf20 - Browse repository at this point
Copy the full SHA 063bf20View commit details -
Configuration menu - View commit details
-
Copy full SHA for a79b2fd - Browse repository at this point
Copy the full SHA a79b2fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 955b7ae - Browse repository at this point
Copy the full SHA 955b7aeView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.30.0...v2.30.1