Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubocop/rubocop-rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.30.0
Choose a base ref
...
head repository: rubocop/rubocop-rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.30.1
Choose a head ref
  • 8 commits
  • 6 files changed
  • 1 contributor

Commits on Feb 15, 2025

  1. Restore useful comment

    koic committed Feb 15, 2025
    Configuration menu
    Copy the full SHA
    ddc7e4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    405faca View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2025

  1. Fix an incorrect behavior when using AllCops: MigratedSchemaVersion

    This PR fixes an incorrect behavior when using `AllCops: MigratedSchemaVersion`.
    
    This suppresses the following warning when `MigratedSchemaVersion` is defined on the user side:
    
    ```console
    $ bundle exec rubocop
    (snip)
    
    Warning: AllCops does not support MigratedSchemaVersion parameter.
    
    Supported parameters are:
    
      - RubyInterpreters
      - Include
      - Exclude
      - DefaultFormatter
      - DisplayCopNames
      - DisplayStyleGuide
      - StyleGuideBaseURL
      - DocumentationBaseURL
      - DocumentationExtension
      - ExtraDetails
      - StyleGuideCopsOnly
      - EnabledByDefault
      - DisabledByDefault
      - NewCops
      - UseCache
      - MaxFilesInCache
      - CacheRootDirectory
      - AllowSymlinksInCacheRootDirectory
      - TargetRubyVersion
      - ParserEngine
      - SuggestExtensions
      - ActiveSupportExtensionsEnabled
      - StringLiteralsFrozenByDefault
    ```
    
    The default value of `AllCops: MigratedSchemaVersion` in `config/default.yml` will change from `null` to the UNIX epoch time,
    but typically, there should be no migration files older than the UNIX epoch time.
    
    This is a bug fix related to the plugin migration in #1434.
    koic committed Feb 16, 2025
    Configuration menu
    Copy the full SHA
    d40c943 View commit details
    Browse the repository at this point in the history
  2. [Fix #1442] Fix an incorrect behavior when using `AllCops: TargetRail…

    …sVersion`
    
    This PR fixes an incorrect behavior when using `AllCops: TargetRailsVersion`.
    
    This suppresses the following warning when `TargetRailsVersion` is defined on the user side:
    
    ```console
    $ bundle exec rubocop
    (snip)
    
    Warning: AllCops does not support TargetRailsVersion parameter.
    
    Supported parameters are:
    
      - RubyInterpreters
      - Include
      - Exclude
      - DefaultFormatter
      - DisplayCopNames
      - DisplayStyleGuide
      - StyleGuideBaseURL
      - DocumentationBaseURL
      - DocumentationExtension
      - ExtraDetails
      - StyleGuideCopsOnly
      - EnabledByDefault
      - DisabledByDefault
      - NewCops
      - UseCache
      - MaxFilesInCache
      - CacheRootDirectory
      - AllowSymlinksInCacheRootDirectory
      - TargetRubyVersion
      - ParserEngine
      - SuggestExtensions
      - ActiveSupportExtensionsEnabled
      - StringLiteralsFrozenByDefault
    ```
    
    This is a dirty hack relying on a private constant to prevent the warning.
    It should be updated to a better design in the future.
    
    Fixes #1442.
    koic committed Feb 16, 2025
    Configuration menu
    Copy the full SHA
    da9d36f View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2025

  1. Merge pull request #1444 from koic/fix_an_incorrect_behavior_when_usi…

    …ng_migrated_schema_version
    
    Fix an incorrect behavior when using `AllCops: MigratedSchemaVersion`
    koic authored Feb 17, 2025
    Configuration menu
    Copy the full SHA
    d8bb510 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1445 from koic/fix_an_error_when_using_target_rai…

    …ls_version
    
    [Fix #1442] Fix an incorrect behavior when using `AllCops: TargetRailsVersion`
    koic authored Feb 17, 2025
    Configuration menu
    Copy the full SHA
    063bf20 View commit details
    Browse the repository at this point in the history
  3. Update Changelog

    koic committed Feb 17, 2025
    Configuration menu
    Copy the full SHA
    a79b2fd View commit details
    Browse the repository at this point in the history
  4. Cut 2.30.1

    koic committed Feb 17, 2025
    Configuration menu
    Copy the full SHA
    955b7ae View commit details
    Browse the repository at this point in the history
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy