Skip to content

fix: loc in rspack error should be object #10610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2025
Merged

fix: loc in rspack error should be object #10610

merged 4 commits into from
Jun 9, 2025

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Jun 9, 2025

Summary

In Webpack the error.loc is object.

interface SyntheticDependencyLocation {
	name: string;
	index?: number;
}

interface RealDependencyLocation {
	start: SourcePosition;
	end?: SourcePosition;
	index?: number;
}

type DependencyLocation = SyntheticDependencyLocation | RealDependencyLocation;

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@SyMind SyMind requested a review from jerrykingxyz as a code owner June 9, 2025 05:35
@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Jun 9, 2025
Copy link

netlify bot commented Jun 9, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit aa7890f
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/684677b81cb5600009054494

Copy link

codspeed-hq bot commented Jun 9, 2025

CodSpeed Performance Report

Merging #10610 will not alter performance

Comparing fix-error-location (aa7890f) with main (0bfad55)

Summary

✅ 12 untouched benchmarks

@JSerFeng JSerFeng merged commit c96a07f into main Jun 9, 2025
34 checks passed
@JSerFeng JSerFeng deleted the fix-error-location branch June 9, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy