fix: use Mutex<Arc<tokio::sync::OnceCell<JsLoaderRunner>>>
to avoid loader runner deadlock
#10632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There could be a deadlock risk with the original implementation. Consider the following execution sequence:
None
.runner.call_async
, which yields to js loaders.loaderContext.importModule
and append a task tomodule_executor
in (assumed) T3. So T1 should wait for T3.tokio::sync::RwLock
(https://docs.rs/tokio/latest/tokio/sync/struct.RwLock.html), T3 will not get the read lock before T2 get the write lock.importModule
), T2 waits for T1 to release its read lock, T3 waits for T2 to acquire and release the write lock.Checklist