Skip to content

refactor: js api readableIdentifier in module #10686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

refactor: js api readableIdentifier in module #10686

merged 1 commit into from
Jun 16, 2025

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Jun 16, 2025 •
edited
Loading

Summary

Refactor readableIdentifier to method in napi.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Jun 16, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 5d340c1
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/684ff4317902550008972ae1

@github-actions github-actions bot added release: refactor team The issue/pr is created by the member of Rspack. labels Jun 16, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 16, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10686 will not alter performance

Comparing refactor-readable-identifier (5d340c1) with main (da689ca)

Summary

✅ 12 untouched benchmarks

@SyMind SyMind marked this pull request as ready for review June 16, 2025 10:36
@SyMind SyMind force-pushed the refactor-readable-identifier branch from e3f627a to 5d340c1 Compare June 16, 2025 10:38
@SyMind SyMind merged commit c0a3622 into main Jun 16, 2025
34 checks passed
@SyMind SyMind deleted the refactor-readable-identifier branch June 16, 2025 11:06
@h-a-n-a h-a-n-a mentioned this pull request Jun 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees
No one assigned
Labels
release: refactor team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SyMind @LingyuCoder
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy