Skip to content

perf: remove visitor feature of lightningcss #10884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Jul 3, 2025

Summary

it seems visitor feature is used for js visitor api which we don't use

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@hardfist hardfist requested a review from JSerFeng as a code owner July 3, 2025 03:36
Copy link

netlify bot commented Jul 3, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit a19ae7b
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6865fac97205f10008e4de3c

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Jul 3, 2025
Copy link
Contributor

github-actions bot commented Jul 3, 2025

📦 Binary Size-limit

Comparing binary size with Commit: chore: Update browserslist-rs to 0.19 (#10872) by quininer

🎉 Size decreased by 2.25KB from 59.79MB to 59.79MB (⬇️0.00%)

@hardfist hardfist enabled auto-merge (squash) July 3, 2025 03:51
Copy link

codspeed-hq bot commented Jul 3, 2025

CodSpeed Performance Report

Merging #10884 will not alter performance

Comparing yj/remove-visitor-feature (a19ae7b) with main (0cb5cc3)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 16 untouched benchmarks

@hardfist hardfist merged commit 07f6697 into main Jul 3, 2025
46 checks passed
@hardfist hardfist deleted the yj/remove-visitor-feature branch July 3, 2025 03:55
@ckken
Copy link

ckken commented Jul 4, 2025

#7608 感觉看到进度又破灭了~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy