feat: support base64 hash digest for css local ident name #10897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
📝 Benchmark detail: Open
|
📦 Binary Size-limit
❌ Size increased by 2.75KB from 59.80MB to 59.80MB (⬆️0.00%) |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for specifying a Base64-encoded hash digest (e.g. [hash:base64:8]) for CSS local identifiers and file placeholders.
- Updates documentation (English and Chinese) to describe the new
base64digest syntax - Extends
replace_all_placeholder_implandrender_templatelogic to parse and emit Base64 digests - Adds test fixtures for CSS
localIdentNameand pulls inrspack_base64as a new dependency
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/config/output.mdx | Documented [hash:base64:8] syntax in Chinese docs |
| website/docs/en/config/output.mdx | Documented [hash:base64:8] syntax in English docs |
| packages/rspack-test-tools/tests/configCases/css/local-ident-name/rspack.config.js | Configured localIdentName to include Base64 hash |
| packages/rspack-test-tools/tests/configCases/css/local-ident-name/index.module.css | Sample CSS class for test |
| packages/rspack-test-tools/tests/configCases/css/local-ident-name/index.js | Assertion for generated class name including Base64 digest |
| crates/rspack_core/src/utils/hash.rs | Enhanced placeholder parser to recognize base64 prefix |
| crates/rspack_core/src/options/filename.rs | Updated placeholder rendering to Base64-encode when requested |
| crates/rspack_core/Cargo.toml | Added rspack_base64 dependency |
Comments suppressed due to low confidence (1)
crates/rspack_core/src/options/filename.rs:281
- Calling
.maponCow<str>may not compile sinceCowdoesn't have amapmethod. Consider slicing&strdirectly or converting to owned string before truncation.
let content = content.map(|s| s[..hash_len(s, len)].into());
chenjiahan
approved these changes
Jul 3, 2025
CodSpeed Performance ReportMerging #10897 will not alter performanceComparing 🎉 Hooray!
|
SyMind
pushed a commit
that referenced
this pull request
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #10881
Related links
Checklist