Skip to content

fix: handle zod type error when skipLibCheck is false #10927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

fix: handle zod type error when skipLibCheck is false #10927

merged 1 commit into from
Jul 7, 2025

Conversation

chenjiahan
Copy link
Member

Summary

The zod dependency is bundled by Rslib. Since Rspack's public APIs do not depend on zod types, we add @ts-ignore to prevent type errors when users set skipLibCheck: false in their tsconfig.json file.

Screenshot 2025-07-07 at 15 45 35

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan chenjiahan requested a review from hardfist as a code owner July 7, 2025 07:46
@netlify Netlify
Copy link

netlify bot commented Jul 7, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 78f9e15
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/686b7b57eaa7d90009e3106a

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jul 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

📦 Binary Size-limit

Comparing binary size with Commit: fix: real content hash replace with slash (#10923) by Gengkun

🙈 Size remains the same at 59.94MB

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 7, 2025

CodSpeed Performance Report

Merging #10927 will not alter performance

Comparing zod_type_error_0707 (78f9e15) with main (be161c0)

Summary

✅ 16 untouched benchmarks

@chenjiahan chenjiahan merged commit 4063d2e into main Jul 7, 2025
47 checks passed
@chenjiahan chenjiahan deleted the zod_type_error_0707 branch July 7, 2025 08:12
@chenjiahan chenjiahan mentioned this pull request Jul 10, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyMind SyMind SyMind approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenjiahan @SyMind
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy