fix!: do not auto-dial peers (#1397)

achingbrain · web-flow · commit ca3019283497 · 2022-10-06T14:14:41.000+01:00
Currently whenever a new peer is discovered we automatically dial them if we are below the connection manager connection limit.

This is incredibly resource intensive and does not necessarily result in high-quality connections (e.g. KAD close, relays or supporting protocols we are interested in).

Now that we can search the DHT for peers, this is no longer necessary so remove the functionality.

BREAKING CHANGE: the old behaviour was to dial any peer we discover, now we just add them to the peer store instead
diff --git a/examples/libp2p-in-the-browser/index.js b/examples/libp2p-in-the-browser/index.js
@@ -54,6 +54,11 @@ document.addEventListener('DOMContentLoaded', async () => {
   libp2p.addEventListener('peer:discovery', (evt) => {
     const peer = evt.detail
     log(`Found peer ${peer.id.toString()}`)
+
+    // dial them when we discover them
+    libp2p.dial(evt.detail.id).catch(err => {
+      log(`Could not dial ${evt.detail.id}`, err)
+    })
   })
 
   // Listen for new connections to peers
diff --git a/examples/peer-and-content-routing/1.js b/examples/peer-and-content-routing/1.js
@@ -38,7 +38,7 @@ const createNode = async () => {
   ])
 
   // The DHT routing tables need a moment to populate
-  await delay(100)
+  await delay(1000)
 
   const peer = await node1.peerRouting.findPeer(node3.peerId)
 
diff --git a/examples/webrtc-direct/dialer.js b/examples/webrtc-direct/dialer.js
@@ -31,6 +31,11 @@ document.addEventListener('DOMContentLoaded', async () => {
   // Listen for new peers
   libp2p.addEventListener('peer:discovery', (evt) => {
     log(`Found peer ${evt.detail.id.toString()}`)
+
+    // dial them when we discover them
+    libp2p.dial(evt.detail.id).catch(err => {
+      log(`Could not dial ${evt.detail.id}`, err)
+    })
   })
 
   // Listen for new connections to peers
diff --git a/src/connection-manager/dialer/auto-dialer.ts b/src/connection-manager/dialer/auto-dialer.ts
diff --git a/src/libp2p.ts b/src/libp2p.ts
@@ -26,7 +26,6 @@ import { PeerRecordUpdater } from './peer-record-updater.js'
 import { DHTPeerRouting } from './dht/dht-peer-routing.js'
 import { PersistentPeerStore } from '@libp2p/peer-store'
 import { DHTContentRouting } from './dht/dht-content-routing.js'
-import { AutoDialer } from './connection-manager/dialer/auto-dialer.js'
 import { Initializable, Components, isInitializable } from '@libp2p/components'
 import type { PeerId } from '@libp2p/interface-peer-id'
 import type { Connection } from '@libp2p/interface-connection'
@@ -238,20 +237,6 @@ export class Libp2pNode extends EventEmitter<Libp2pEvents> implements Libp2p {
       ...init.ping
     }))
 
-    const autoDialer = this.configureComponent(new AutoDialer(this.components, {
-      enabled: init.connectionManager.autoDial !== false,
-      minConnections: init.connectionManager.minConnections,
-      dialTimeout: init.connectionManager.dialTimeout ?? 30000
-    }))
-
-    this.addEventListener('peer:discovery', evt => {
-      if (!this.isStarted()) {
-        return
-      }
-
-      autoDialer.handle(evt)
-    })
-
     // Discovery modules
     for (const service of init.peerDiscovery ?? []) {
       this.configureComponent(service)
