Scribd
Upload
53 views

Code Review Best Practices

The document outlines best practices for code review, including why code reviews are important for sharing knowledge, consistency, reducing risks and ensuring compliance. It recommends preparing code for review by submitting complete, self-reviewed changes in small, tested units with clear commit messages. The document also stresses the importance of code review culture and concludes by emphasizing careful coding, self-improvement, and focusing on programs over stylistic debates.

Uploaded by

Lê Phương Tiến
Copyright
© © All Rights Reserved
We take content rights seriously. If you suspect this is your content, claim it here.
Available Formats
Download as PPTX, PDF, TXT or read online on Scribd
53 views

Code Review Best Practices

The document outlines best practices for code review, including why code reviews are important for sharing knowledge, consistency, reducing risks and ensuring compliance. It recommends preparing code for review by submitting complete, self-reviewed changes in small, tested units with clear commit messages. The document also stresses the importance of code review culture and concludes by emphasizing careful coding, self-improvement, and focusing on programs over stylistic debates.

Uploaded by

Lê Phương Tiến
Copyright
© © All Rights Reserved
We take content rights seriously. If you suspect this is your content, claim it here.
Available Formats
Download as PPTX, PDF, TXT or read online on Scribd
You are on page 1/ 11

CODE REVIEW BEST PRACTICES

Thinh Ung V.
iOS team
How do you
contribute for
project team?
Coding and reviewing
● Why, what and when?

● Preparing code for review


Contents
● Performing code reviews

● Code review culture


Why
1. Sharing knowledge

2. Consistency

3. Reduce risks

4. Compliance
What to review

No answer
When
After automated checks “Hú hú, review please”

Test, style, CIs


Preparing code for review
1. Scope and size

2. Only submit complete, self-reviewed


(by diff), and self-tested CRs

3. Divide into multiple units

4. “Nây-xà” commit message


Code review No
culture more
word
Conclusion
- Be careful coding and reviewing
- Improve by your-self
- Focus on program rather than style, syntax, or formatting debates
It’s time for sharing

You might also like

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy